Bugzilla – Attachment 155945 Details for
Bug 12532
Copy guarantee email to guarantor (or redirect if guarantee has no email set)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12532: Fix test
Bug-12532-Fix-test.patch (text/plain), 2.21 KB, created by
Martin Renvoize (ashimema)
on 2023-09-20 14:12:34 UTC
(
hide
)
Description:
Bug 12532: Fix test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-09-20 14:12:34 UTC
Size:
2.21 KB
patch
obsolete
>From 1a028215821464012d10df62eb5c88deb8001568 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 19 Sep 2023 11:14:42 +0200 >Subject: [PATCH] Bug 12532: Fix test > >The mock was working. The problem was that the to_address of the notice >was set from the previous send. > >A fix would be to update the message, but it seems better to simply >re-enqueue it. > >This patch also use Koha::Notice::Messages. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Letters.t | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index 88af0b0b580..66d51acdc5e 100755 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -957,7 +957,7 @@ subtest 'Test SMS handling in SendQueuedMessages' => sub { > > subtest 'Test guarantor handling in SendQueuedMessages' => sub { > >- plan tests => 8; >+ plan tests => 7; > > t::lib::Mocks::mock_preference( 'borrowerRelationship', 'test' ); > >@@ -1012,18 +1012,18 @@ subtest 'Test guarantor handling in SendQueuedMessages' => sub { > is( $email_object->email->header('Cc'), $guarantor2->email, "cc correctly uses second guarantor" ); > > # feature disabled >- t::lib::Mocks::mock_preference( 'RedirectGuaranteeEmail', '0' ); #FIXME: This mock is failing!? >+ t::lib::Mocks::mock_preference( 'RedirectGuaranteeEmail', '0' ); > > # reset message >- $schema->resultset('MessageQueue')->search( { borrowernumber => $borrowernumber, status => 'sent' } ) >- ->update( { status => 'pending', failure_code => undef } ); >+ Koha::Notice::Messages->find($message_id)->delete; > >+ $message_id = C4::Letters::EnqueueLetter($my_message); > warning_like { C4::Letters::SendQueuedMessages(); } > qr|No 'to_address', email address or guarantors email address for borrowernumber|, > "SendQueuedMessages fails when no to_address, patron notice email and RedirectGuaranteeEmail is not set"; > > # clear borrower queue >- $schema->resultset('MessageQueue')->search( { borrowernumber => $borrowernumber, status => 'sent' } )->delete(); >+ Koha::Notice::Messages->find($message_id)->delete; > }; > > subtest 'get_item_content' => sub { >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12532
:
29510
|
30747
|
35313
|
36752
|
39787
|
39925
|
48645
|
53649
|
53689
|
53690
|
53699
|
53700
|
55985
|
56052
|
56053
|
59445
|
59446
|
59447
|
63197
|
64802
|
64824
|
67115
|
68340
|
70865
|
72064
|
72617
|
75099
|
77606
|
80313
|
85134
|
85135
|
87815
|
87816
|
88208
|
88209
|
88210
|
88211
|
88212
|
88213
|
88295
|
88296
|
114455
|
114456
|
114457
|
114458
|
114459
|
114460
|
114461
|
131091
|
131092
|
131093
|
131094
|
149233
|
150071
|
150208
|
150217
|
150240
|
150256
|
151028
|
151029
|
154854
|
154855
|
154856
|
154857
|
155036
|
155037
|
155828
|
155829
|
155830
|
155831
|
155832
|
155833
|
155834
|
155835
|
155836
|
155837
|
155873
|
155874
|
155875
|
155876
|
155877
|
155878
|
155879
|
155880
|
155881
|
155882
|
155883
|
155886
|
155934
|
155935
|
155936
|
155937
|
155938
|
155939
|
155940
|
155941
|
155942
|
155943
|
155944
| 155945 |
155946