Attachment 155955 Details for Bug 34834 – Bug 34834: Add translation context for "Order"

[patch] Bug 34834: Add translation context for "Order"

Bug-34834-Add-translation-context-for-Order.patch (text/plain), 5.26 KB, created by Owen Leonard on 2023-09-20 16:55:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-09-20 16:55:04 UTC

Size: 5.26 KB

patch

obsolete

>From 2ef1e010e633c3ce62f62588a4f64f782ef81e0a Mon Sep 17 00:00:00 2001
>From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>Date: Wed, 20 Sep 2023 10:24:02 -0400
>Subject: [PATCH] Bug 34834: Add translation context for "Order"
>
>This patch adds context for translation to the term "Order". It is
>sometimes used as a verb (e.g. to order) and sometimes as a noun (e.g.
>an order).
>
>To test:
>1. Go to the various pages and make sure Order appears correctly in
>   English
>
>   -  orderreceive: when receiving multiple orders, the table heading
>   -  parcel: when receiving an order, there is a "View" menu with
>      "Order", "MARC", and "Card"
>   -  z3950_search: when adding an order from an external source, if
>      you hover the mouse on the Order option, there is a thing that
>      opens (a tooltip?) with the word "Order"
>
>2. Apply patch
>
>3. Redo step 1 in English, make sure the pages still work
>
>4. Update the translation files
>
>   gulp po:update --lang fr-CA
>
>5. View the messages.po file and make sure the term is translated for
>   both verb and noun context (you can put anything, just something
>   different to tell them apart)
>
>6. View the pages in the other language, the terms should be
>
>   -  orderreceive: noun
>   -  parcel: noun
>   -  z3950_search: verb
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt       | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>index 455cbb3056..1670b8241e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>@@ -108,7 +108,7 @@
>     <table id="multiple_orders" class="table table-bordered table-striped">
>         <thead>
>             <tr>
>-                <th>Order</th>
>+                <th>[% tp('noun', 'Order') | html %]</th>
>                 <th>Title</th>
>                 <th>Author</th>
>                 <th>ISBN</th>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>index c2eaea312e..c015324c2b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>@@ -532,7 +532,7 @@
>                                 result += ' <span class="caret"></span> ';
>                             result += '</button>';
>                             result += '<ul class="dropdown-menu" aria-labelledby="view' + row.order_id + '">';
>-                                result += '<li><a href="/cgi-bin/koha/acqui/showorder.pl?ordernumber=' + encodeURIComponent(row.order_id) + '" class="previewData">' + _("Order") + '</a></li>';
>+                                result += '<li><a href="/cgi-bin/koha/acqui/showorder.pl?ordernumber=' + encodeURIComponent(row.order_id) + '" class="previewData">[% tp("noun", "Order") | html %]</a></li>';
>                                 result += '<li><a href="/cgi-bin/koha/catalogue/showmarc.pl?id=' + encodeURIComponent(row.biblio_id) + '" class="previewData">' + _("MARC") + '</a></li>';
>                                 result += '<li><a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&amp;id=' + encodeURIComponent(row.biblio_id) + '" class="previewData">' + _("Card") + '</a></li>';
>                             result += '</ul>';
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
>index a458291dba..92507070c4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
>@@ -218,7 +218,7 @@ tr.selected td {
>                     <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="z3950preview[% breeding_loo.breedingid | html %]">
>                         <li><a href="/cgi-bin/koha/catalogue/showmarc.pl?importid=[% breeding_loo.breedingid | uri %]" title="MARC" class="previewData" data-action="show_marc"><i class="fa-solid fa-eye"></i> MARC</a></li>
>                         <li><a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&amp;importid=[% breeding_loo.breedingid | uri %]" title="Card" class="previewData" data-action="show_card"><i class="fa-solid fa-eye"></i> Card</a></li>
>-                        <li><a href="/cgi-bin/koha/acqui/neworderempty.pl?frameworkcode=[% frameworkcode | uri %]&amp;breedingid=[% breeding_loo.breedingid | uri %]&amp;booksellerid=[% booksellerid | uri %]&amp;basketno=[% basketno | uri %]" class="chosen" title="Order" data-action="order"><i class="fa fa-plus"></i> [% tp('verb', 'Order') | html %]</a></li>
>+                        <li><a href="/cgi-bin/koha/acqui/neworderempty.pl?frameworkcode=[% frameworkcode | uri %]&amp;breedingid=[% breeding_loo.breedingid | uri %]&amp;booksellerid=[% booksellerid | uri %]&amp;basketno=[% basketno | uri %]" class="chosen" title="[% tp('verb', 'Order') | html %]" data-action="order"><i class="fa fa-plus"></i> [% tp('verb', 'Order') | html %]</a></li>
>                     </ul>
>                 </div>
>             </td>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34834: 155948 | 155955 | 158139