Bugzilla – Attachment 156015 Details for
Bug 34199
Add part_name and part_number to subscription detail page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34199: Add full title information to subscription detail page
Bug-34199-Add-full-title-information-to-subscripti.patch (text/plain), 4.83 KB, created by
Chris Cormack
on 2023-09-21 21:11:39 UTC
(
hide
)
Description:
Bug 34199: Add full title information to subscription detail page
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2023-09-21 21:11:39 UTC
Size:
4.83 KB
patch
obsolete
>From 0110a3ed5bb5fcdb0ed7184d02ecaa7db202d4c6 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Fri, 7 Jul 2023 15:27:42 +0000 >Subject: [PATCH] Bug 34199: Add full title information to subscription detail > page > >Show the full title information, including part_name and part_number >on the subscription detail page. > >To test: >* Add a subscription linked to a record with 245$abnp set >* Verify only 245$ab will show up on the subscription detail page >* Apply patch >* Verify that the full title information shows up on the detail page > >Signed-off-by: Sam Lau <samalau@gmail.com> >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > .../prog/en/modules/serials/subscription-detail.tt | 8 ++++++-- > serials/subscription-detail.pl | 10 ++++------ > 2 files changed, 10 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index 3d3d5a5052a..e596aba7027 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -7,6 +7,7 @@ > [% USE Price %] > [% USE TablesSettings %] > [% SET footerjs = 1 %] >+[%- PROCESS 'html_helpers.inc' -%] > [% INCLUDE 'doc-head-open.inc' %] > <title>Details for subscription #[% subscriptionid | html %] › Serials › Koha</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -42,7 +43,7 @@ > [% INCLUDE 'serials-toolbar.inc' %] > [% INCLUDE 'mana/mana-comment-status.inc' %] > >- <h1>Subscription for [% bibliotitle | html %] [% bibliosubtitle | html %] [% IF closed %](closed)[% END %]</h1> >+ <h1>Subscription for [% INCLUDE 'biblio-title.inc' biblio=subscription.biblio link = 0 %] [% IF closed %](closed)[% END %]</h1> > > [% IF ( abouttoexpire ) %] > [% UNLESS closed %] >@@ -102,7 +103,10 @@ > <li><span class="label">Subscription ID: </span>[% subscriptionid | html %]</li> > <li><span class="label">Librarian identity:</span> [% librarian | html %]</li> > <li><span class="label">Vendor:</span> <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% aqbooksellerid | uri %]">[% aqbooksellername | html %]</a></li> >- <li><span class="label">Biblio:</span> <a href="[% PROCESS biblio_a_href biblionumber => bibnum %]">[% bibliotitle | html %] [% bibliosubtitle | html %]</a> <em>([% bibnum | html %])</em></li> >+ <li> >+ <span class="label">Bibliographic record:</span> >+ [%- INCLUDE 'biblio-title.inc' biblio=subscription.biblio link = 1 -%] <em>([% subscription.biblionumber | html %])</em> >+ </li> > [% IF ( OPACBaseURL ) %] > <li> > <span class="label">OPAC view:</span> >diff --git a/serials/subscription-detail.pl b/serials/subscription-detail.pl >index 2ae5cd3ef74..74a0ee8aabb 100755 >--- a/serials/subscription-detail.pl >+++ b/serials/subscription-detail.pl >@@ -36,8 +36,9 @@ use Koha::SharedContent; > my $query = CGI->new; > my $op = $query->param('op') || q{}; > my $issueconfirmed = $query->param('issueconfirmed'); >-my $dbh = C4::Context->dbh; >+my $dbh = C4::Context->dbh; > my $subscriptionid = $query->param('subscriptionid'); >+my $subscription = Koha::Subscriptions->find( $subscriptionid ); > > if ( $op and $op eq "close" ) { > C4::Serials::CloseSubscription( $subscriptionid ); >@@ -124,13 +125,9 @@ my @irregular_issues = split /;/, $subs->{irregularity}; > my $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subs->{periodicity}); > my $numberpattern = C4::Serials::Numberpattern::GetSubscriptionNumberpattern($subs->{numberpattern}); > >-my $subscription_object = Koha::Subscriptions->find( $subscriptionid ); > $template->param( > available_additional_fields => Koha::AdditionalFields->search( { tablename => 'subscription' } ), >- additional_field_values => { >- map { $_->field->name => $_->value } >- $subscription_object->additional_field_values->as_list >- }, >+ additional_field_values => { map { $_->field->name => $_->value } $subscription->additional_field_values->as_list }, > ); > > # FIXME Do we want to hide canceled orders? >@@ -151,6 +148,7 @@ while ( my $o = $orders->next ) { > } > > $template->param( >+ subscription => $subscription, > subscriptionid => $subscriptionid, > serialslist => \@serialslist, > hasRouting => $hasRouting, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34199
:
153186
|
153187
| 156015