Attachment 156028 Details for Bug 34720 – Bug 34720: Fix bug 30403 atomic update

[patch] Bug 34720: Fix bug 30403 atomic update

Bug-34720-Fix-bug-30403-atomic-update.patch (text/plain), 3.35 KB, created by Jonathan Druart on 2023-09-22 06:31:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-09-22 06:31:37 UTC

Size: 3.35 KB

patch

obsolete

>From f1301a7e8f4746559fe65cf26ba19b29e6128b79 Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Thu, 21 Sep 2023 11:49:12 +0300
>Subject: [PATCH] Bug 34720: Fix bug 30403 atomic update
>
>Bug 30403 had wrong syspref name in its
>atomic update file. This patch fixes this in
>db_rev 221200018.pl and adds new atomic
>update file.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> installer/data/mysql/atomicupdate/bug_30403.pl | 18 ++++++++++++++++++
> installer/data/mysql/db_revs/221200018.pl      |  4 ++--
> 2 files changed, 20 insertions(+), 2 deletions(-)
> create mode 100755 installer/data/mysql/atomicupdate/bug_30403.pl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_30403.pl b/installer/data/mysql/atomicupdate/bug_30403.pl
>new file mode 100755
>index 00000000000..4e91ec1de7c
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_30403.pl
>@@ -0,0 +1,18 @@
>+use Modern::Perl;
>+
>+return {
>+    bug_number  => "34720",
>+    description => "Add system preference UpdateNotForLoanStatusOnCheckout",
>+    up          => sub {
>+        my ($args) = @_;
>+        my ( $dbh, $out ) = @$args{qw(dbh out)};
>+
>+        $dbh->do(
>+            q{
>+                INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type )
>+                VALUES ('UpdateNotForLoanStatusOnCheckout', '', 'NULL', 'This is a list of value pairs. When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value. E.g. ''-1: 0'' will cause an item that was set to ''Ordered'' to now be available for loan. Each pair of values should be on a separate line.', 'Free')
>+            }
>+        );
>+        say $out "Added new system preference 'UpdateNotForLoanStatusOnCheckout'";
>+    },
>+};
>diff --git a/installer/data/mysql/db_revs/221200018.pl b/installer/data/mysql/db_revs/221200018.pl
>index e155df848b9..035aaa854f8 100755
>--- a/installer/data/mysql/db_revs/221200018.pl
>+++ b/installer/data/mysql/db_revs/221200018.pl
>@@ -2,11 +2,11 @@ use Modern::Perl;
> 
> return {
>     bug_number => "30403",
>-    description => "Add system preference UpdateNotForLoanStatusOnCheckin",
>+    description => "Add system preference UpdateNotForLoanStatusOnCheckout",
>     up => sub {
>         my ($args) = @_;
>         my ($dbh, $out) = @$args{qw(dbh out)};
>         # Do you stuffs here
>-        $dbh->do(q{INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES ('UpdateNotForLoanStatusOnCheckin', '', 'NULL', 'This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value. E.g. ''-1: 0'' will cause an item that was set to ''Ordered'' to now be available for loan. Each pair of values should be on a separate line.', 'Free')});
>+        $dbh->do(q{INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES ('UpdateNotForLoanStatusOnCheckout', '', 'NULL', 'This is a list of value pairs. When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value. E.g. ''-1: 0'' will cause an item that was set to ''Ordered'' to now be available for loan. Each pair of values should be on a separate line.', 'Free')});
>     },
> };
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 34720: 155968 | 156028 | 156029 | 156031 | 156032