Bugzilla – Attachment 156038 Details for
Bug 34848
SIP/Message.t is failing if the DB has been upgraded
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34848: (QA follow-up) Resolve warn on useless constant
Bug-34848-QA-follow-up-Resolve-warn-on-useless-con.patch (text/plain), 1.04 KB, created by
Marcel de Rooy
on 2023-09-22 08:54:45 UTC
(
hide
)
Description:
Bug 34848: (QA follow-up) Resolve warn on useless constant
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-09-22 08:54:45 UTC
Size:
1.04 KB
patch
obsolete
>From f767ff600ebb0487eafae1779273ceb7ed27d262 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 22 Sep 2023 08:51:59 +0000 >Subject: [PATCH] Bug 34848: (QA follow-up) Resolve warn on useless constant >Content-Type: text/plain; charset=utf-8 > >Useless use of a constant ("Dies if sip user cannot be found") in void context at t/db_dependent/SIP/Message.t line 582. > >We should remove the comma.. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/SIP/Message.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/SIP/Message.t b/t/db_dependent/SIP/Message.t >index 0ac278c4b3..a8b4ef70bb 100755 >--- a/t/db_dependent/SIP/Message.t >+++ b/t/db_dependent/SIP/Message.t >@@ -579,7 +579,7 @@ subtest 'SC status tests' => sub { > > $sip_user->delete; > >- dies_ok{ $msg->handle_sc_status( $server ) } ,"Dies if sip user cannot be found"; >+ dies_ok { $msg->handle_sc_status( $server ) } "Dies if sip user cannot be found"; > > $schema->storage->txn_rollback; > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34848
:
155932
|
155963
|
156037
| 156038