Bugzilla – Attachment 156172 Details for
Bug 34737
Enhance SIP2SortBinMapping to support additional match conditions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34737: (follow-up) Squelch a warning
Bug-34737-follow-up-Squelch-a-warning.patch (text/plain), 1.14 KB, created by
Martin Renvoize (ashimema)
on 2023-09-25 14:31:24 UTC
(
hide
)
Description:
Bug 34737: (follow-up) Squelch a warning
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-09-25 14:31:24 UTC
Size:
1.14 KB
patch
obsolete
>From fc85071cab59934ecfbcc30611dfeeaa0dbf09b4 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 7 Sep 2023 17:24:24 +0100 >Subject: [PATCH] Bug 34737: (follow-up) Squelch a warning > >We weren't checking whether an item property was defined or not and as >such the new test highlighted a new warning. > >Signed-off-by: Toni Ford <Toni.Ford@newcastle.gov.uk> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/SIP/ILS/Transaction/Checkin.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index 63e017018fd..bf4a17720a5 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -292,6 +292,7 @@ sub _get_sort_bin { > > # Check the fields against values in the item > my $property = $item->$item_property; >+ next RULE unless defined($property); > if ( ( $comparator eq 'eq' || $comparator eq '=' ) && ( $property eq $value ) ) { > $match = 1; > } elsif ( ( $comparator eq 'ne' || $comparator eq '!=' ) && ( $property ne $value ) ) { >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34737
:
155328
|
155329
|
155330
|
155360
|
155361
|
155362
|
155663
|
155664
|
155665
|
155666
|
156147
|
156148
|
156170
|
156171
| 156172 |
156173
|
156174
|
156175
|
156176
|
156177
|
156314
|
156315