Bugzilla – Attachment 156180 Details for
Bug 34905
ILL - "Place request with partners" icon is gone
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34905: Fix icon
Bug-34905-Fix-icon.patch (text/plain), 2.27 KB, created by
Pedro Amorim
on 2023-09-25 16:10:12 UTC
(
hide
)
Description:
Bug 34905: Fix icon
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-09-25 16:10:12 UTC
Size:
2.27 KB
patch
obsolete
>From c7757b20832791eb4c440000d0907d20d6a5339e Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 25 Sep 2023 16:10:06 +0000 >Subject: [PATCH] Bug 34905: Fix icon > >Test plan, on k-t-d: >1) Install FreeForm, run: >bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) > >2) Create a new FreeForm ILL request: >http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm > >3) Pick a request type and input "42" in cardnumber and select a random library. > >4) Notice the "Place request with partners" icon is gone from the top action bar. > >5) Apply patch. Repeat. >--- > Koha/Illrequest.pm | 2 +- > t/db_dependent/Illrequests.t | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index 87b1179cba..774b5071f5 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -531,7 +531,7 @@ sub _core_status_graph { > ui_method_name => 'Place request with partners', > method => 'generic_confirm', > next_actions => [ 'COMP', 'CHK', 'REQREV' ], >- ui_method_icon => 'fa-send-o', >+ ui_method_icon => 'fa-paper-plane', > }, > REQREV => { > prev_actions => [ 'REQ', 'GENREQ' ], >diff --git a/t/db_dependent/Illrequests.t b/t/db_dependent/Illrequests.t >index ad2245ec4e..bf1d6e7bf1 100755 >--- a/t/db_dependent/Illrequests.t >+++ b/t/db_dependent/Illrequests.t >@@ -350,7 +350,7 @@ subtest 'Status Graph tests' => sub { > ui_method_name => 'Place request with partners', > method => 'generic_confirm', > next_actions => [ 'COMP', 'CHK', 'REQREV' ], >- ui_method_icon => 'fa-send-o', >+ ui_method_icon => 'fa-paper-plane', > }, > REQREV => { > prev_actions => [ 'REQ', 'GENREQ' ], >@@ -469,7 +469,7 @@ subtest 'Status Graph tests' => sub { > ui_method_name => 'Place request with partners', > method => 'generic_confirm', > next_actions => [ 'COMP', 'CHK', 'REQREV' ], >- ui_method_icon => 'fa-send-o', >+ ui_method_icon => 'fa-paper-plane', > }, > REQREV => { > prev_actions => [ 'REQ', 'GENREQ' ], >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34905
:
156180
|
156181
|
156388