Bugzilla – Attachment 156204 Details for
Bug 34838
The ILL module and tests generate warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34838: Tidy
Bug-34838-Tidy.patch (text/plain), 2.74 KB, created by
Pedro Amorim
on 2023-09-26 09:42:12 UTC
(
hide
)
Description:
Bug 34838: Tidy
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-09-26 09:42:12 UTC
Size:
2.74 KB
patch
obsolete
>From b838d2b1077fe1dfa587c52ac9f21d64af2a631e Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 26 Sep 2023 09:42:27 +0000 >Subject: [PATCH] Bug 34838: Tidy > >--- > Koha/Illbackend.pm | 4 ++-- > Koha/Illrequest.pm | 24 ++++++++++++++---------- > 2 files changed, 16 insertions(+), 12 deletions(-) > >diff --git a/Koha/Illbackend.pm b/Koha/Illbackend.pm >index 6d95b5e2a7..4b1c2ed784 100644 >--- a/Koha/Illbackend.pm >+++ b/Koha/Illbackend.pm >@@ -35,7 +35,7 @@ New illbackend > > sub new { > my $class = shift; >- my $self = {}; >+ my $self = {}; > return bless $self, $class; > } > >@@ -117,7 +117,7 @@ sub embed { > > foreach my $embed_req ( split /\s*,\s*/, $embed_header ) { > if ( $embed_req eq 'statuses+strings' ) { >- $return_embed->{statuses} = $self->existing_statuses( $backend_id ); >+ $return_embed->{statuses} = $self->existing_statuses($backend_id); > } > } > return $return_embed; >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index a390053fb7..67796afc8e 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -1951,21 +1951,25 @@ sub strings_map { > } > > my $status_string = >- ( $self->status && exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{name} ) >- ? $status_graph_union->{ $self->status }->{name} >- : $self->status; >+ ( $self->status >+ && exists $status_graph_union->{ $self->status } >+ && defined $status_graph_union->{ $self->status }->{name} ) >+ ? $status_graph_union->{ $self->status }->{name} >+ : $self->status; > > my $status_code = >- ( $self->status && exists $status_graph_union->{ $self->status } && defined $status_graph_union->{ $self->status }->{id} ) >- ? $status_graph_union->{ $self->status }->{id} >- : $self->status; >+ ( $self->status >+ && exists $status_graph_union->{ $self->status } >+ && defined $status_graph_union->{ $self->status }->{id} ) >+ ? $status_graph_union->{ $self->status }->{id} >+ : $self->status; > > my $strings = { > status => { >- backend => $self->backend, # the backend identifier >- str => $status_string, # the status description, taken from the status graph >- code => $status_code, # the status id, taken from the status graph >- type => 'ill_status', # fixed type >+ backend => $self->backend, # the backend identifier >+ str => $status_string, # the status description, taken from the status graph >+ code => $status_code, # the status id, taken from the status graph >+ type => 'ill_status', # fixed type > } > }; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34838
:
156178
|
156200
|
156201
|
156202
|
156204
|
156217
|
156218
|
156219
|
156220
|
166841
|
166842
|
166843
|
166844
|
166845
|
166846
|
166847
|
166848
|
166849
|
166850
|
166851
|
166852
|
166853
|
166854
|
166855
|
167193
|
167194
|
167211
|
167212
|
167213
|
167214
|
167215
|
167216