Attachment 156210 Details for Bug 33395 – Bug 33395: Patron search results - show number of overdues and checkouts when patrons have overdues

[patch] Bug 33395: Patron search results - show number of overdues and checkouts when patrons have overdues

Bug-33395-Patron-search-results---show-number-of-o.patch (text/plain), 2.48 KB, created by Jonathan Druart on 2023-09-26 10:01:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-09-26 10:01:31 UTC

Size: 2.48 KB

patch

obsolete

>From bff101517788d9fb9bb42cc868ec9c1c768ccf7c Mon Sep 17 00:00:00 2001
>From: David Nind <david@davidnind.com>
>Date: Sat, 23 Sep 2023 01:10:31 +0000
>Subject: [PATCH] Bug 33395: Patron search results - show number of overdues
> and checkouts when patrons have overdues
>
>This fixes the display of patron search results, so that it shows
>the number of checkouts when a patron has overdue items. For
>example: 1 / 2
>
>Bug 30063 changed the display to show only the number of overdue
>items in bold and red, without the total number of items checked
>out.
>
>Test plan:
>1. Check out two items to a patron - make one overdue (click the
> checkout setting options and then specify a due date a month
> ago).
>2. Check out another item to another patron.
>3. Search for patrons so that the two patrons you checked out
> items to are listed in the results.
>4. Note the display for the 'Checkouts' column:
> 4.1 For patrons without any checkouts: 0 / 0
> 4.2 For the patron from step 2 with one checkout: 0 / 1
> 4.3 For the patron from step 1 with one overdue and one
> checkout: 1 (in bold and red)
>5. Apply the patch.
>6. Refresh the page of results (step 3).
>7. Note that for the patron from step 1, the display now shows:
> 1 / 2 (with the 1 in bold and red).
>8. Sign off! 8-)
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>index 1e9ff498dbe..90a7aa1a79c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>@@ -582,7 +582,7 @@
> "orderable": false,
> "render": function( data, type, row, meta ) {
> if ( row.overdues_count ) {
>- return ""+row.overdues_count + "";
>+ return ""+row.overdues_count + "" + " / " + row.checkouts_count;
> } else {
> return "0 / " + row.checkouts_count;
> }
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 33395: 156127 | 156134 | 156210