Attachment 156217 Details for Bug 34838 – Bug 34838: Replace SUPER::AUTOLOAD with get_column

[patch] Bug 34838: Replace SUPER::AUTOLOAD with get_column

Bug-34838-Replace-SUPERAUTOLOAD-with-getcolumn.patch (text/plain), 1.98 KB, created by Nick Clemens (kidclamp) on 2023-09-26 11:20:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-09-26 11:20:20 UTC

Size: 1.98 KB

patch

obsolete

>From 2a57b321e1381910d37a0275002029158d0a16a5 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 25 Sep 2023 15:07:37 +0000
>Subject: [PATCH] Bug 34838: Replace SUPER::AUTOLOAD with get_column
>
>I'm not 100% happy with this but I'm out of ideas.
>
>I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously.
>
>Test plan:
>  prove t/db_dependent/Koha/Illbackend.t
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/Illrequest.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index 87b1179cba..518e7d497f 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -278,7 +278,7 @@ correct category and records the fact that the status has changed
> sub status_alias {
>     my ($self, $new_status_alias) = @_;
> 
>-    my $current_status_alias = $self->SUPER::status_alias;
>+    my $current_status_alias = $self->get_column('status_alias');
> 
>     if ($new_status_alias) {
>         # Keep a record of the previous status before we change it,
>@@ -313,7 +313,7 @@ sub status_alias {
>     my $alias = Koha::AuthorisedValues->search(
>         {
>             category         => 'ILL_STATUS_ALIAS',
>-            authorised_value => $self->SUPER::status_alias
>+            authorised_value => $current_status_alias
>         },
>         {},
>         $self->branchcode
>@@ -339,8 +339,8 @@ and sends a notice if appropriate
> sub status {
>     my ( $self, $new_status) = @_;
> 
>-    my $current_status = $self->SUPER::status;
>-    my $current_status_alias = $self->SUPER::status_alias;
>+    my $current_status = $self->get_column('status');
>+    my $current_status_alias = $self->get_column('status_alias');
> 
>     if ($new_status) {
>         # Keep a record of the previous status before we change it,
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34838: 156178 | 156200 | 156201 | 156202 | 156204 | 156217 | 156218 | 156219 | 156220 | 166841 | 166842 | 166843 | 166844 | 166845 | 166846 | 166847 | 166848 | 166849 | 166850 | 166851 | 166852 | 166853 | 166854 | 166855 | 167193 | 167194 | 167211 | 167212 | 167213 | 167214 | 167215 | 167216