Attachment 15624 Details for Bug 9694 – Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages

[patch] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages

Bug-9694---Remove-YUI-styling-from-buttons-on-the-.patch (text/plain), 5.03 KB, created by Owen Leonard on 2013-02-22 15:40:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2013-02-22 15:40:16 UTC

Size: 5.03 KB

patch

obsolete

>From 8f11f3f908d9dc212464e99f6b726f46cae5c71c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 22 Feb 2013 09:26:01 -0500
>Subject: [PATCH] Bug 9694 - Remove YUI styling from buttons on the patron
> card creator manage pages
>Content-Type: text/plain; charset="utf-8"
>
>Buttons on the patron card creator's manage pages (manage templates,
>manage profiles, etc) are styled using YUI. They can be classified as
>submit buttons rather than toolbar buttons, so they should have default
>submit button styles.
>
>This patch removes YUI styling and related JavaScript. Other minor
>changes: Escaping strings in JavaScript for translation.
>
>To test, view the patron card creator's manage page for layouts,
>templates, profiles, and batches. "Edit," "Delete," and "Export" buttons
>should look correct and work correctly.
>---
> .../prog/en/modules/patroncards/manage.tt          |   58 ++++++--------------
> 1 file changed, 18 insertions(+), 40 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
>index afb466b..927839d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
>@@ -7,7 +7,7 @@
>             function DeleteConfirm() {
>                 var element_id = selected_layout("delete");
>                 if (element_id>-1) {
>-                    var msg = "Are you sure you want to delete [% card_element %] " + element_id + "?"
>+                    var msg = _("Are you sure you want to delete") + " [% card_element %] " + element_id + "?"
>                     var answer = confirm(msg);
>                     if (answer) {
>                         window.location = "/cgi-bin/koha/patroncards/manage.pl?op=delete&card_element=[% card_element %]&element_id=" + element_id;
>@@ -50,7 +50,7 @@
>                     alert(_("Please select at least one batch to export."));
>                     return;     // no batch selected
>                 }
>-                return GB_showCenter('Export Patron Cards', "/cgi-bin/koha/patroncards/print.pl?" + getstr, 700, 800);
>+                return GB_showCenter(_('Export patron cards'), "/cgi-bin/koha/patroncards/print.pl?" + getstr, 700, 800);
>             };
>             function selected_layout(op) {
>                 var selected = new Array;
>@@ -76,45 +76,23 @@
>                 alert(_("Please select a ")+"[% card_element %].");
>                 return (-1);
>             };
>-        //]]>
>-    </script>
>-    <script type="text/javascript">
>-        //<![CDATA[
>-        $(document).ready(function() {
>-            $("#edit").empty();
>-            $("#delete").empty();
>-            [% IF ( print ) %]
>-            $("#xport").empty();
>-            [% END %]
>-            buildButtons();
>-         });
> 
>-        function buildButtons() {
>-            var editButton = new YAHOO.widget.Button({
>-                type: "link",
>-                onclick: {fn: Edit},
>-                label: _("Edit"),
>-                id: "edit",
>-                container: "edit"
>+        $(document).ready(function() {
>+            $("#edit").click(function(){
>+                Edit();
>+                return false;
>             });
>-            var deleteButton = new YAHOO.widget.Button({
>-                type: "link",
>-                onclick: {fn: DeleteConfirm},
>-                label: _("Delete"),
>-                id: "delete",
>-                container: "delete",
>+            $("#delete").click(function(){
>+                DeleteConfirm();
>+                return false;
>             });
>-            [% IF ( print ) %]
>-            var xportButton = new YAHOO.widget.Button({
>-                type: "link",
>-                onclick: {fn: Xport},
>-                label: _("Export"),
>-                id: "xport",
>-                container: "xport",
>+            $("#print").click(function(){
>+                Xport();
>+                return false;
>             });
>-            [% END %]
>-        };
>-    </script>
>+         });
>+//]]>
>+</script>
> </head>
> <body id="pcard_manage" class="tools pcard">
>     [% INCLUDE 'header.inc' %]
>@@ -161,9 +139,9 @@
>                                 [% END %]
>                             </table>
>                             <fieldset class="action">
>-                                <span id="edit"><input type="button" id="edit" onclick="Edit()" value="Edit" /></span>
>-                                <span id="delete"><input type="button" id="delete" onclick="DeleteConfirm()" value="Delete" /></span>
>-                                [% IF ( print ) %]<span id="xport"><input type="button" id="print" onclick="Xport()" value="Export" /></span>[% END %]
>+                                <input type="button" id="edit" value="Edit" />
>+                                <input type="button" id="delete" value="Delete" />
>+                                [% IF ( print ) %]<input type="button" id="print" value="Export" />[% END %]
>                             </fieldset>
>                             </form>
>                             [% ELSE %]
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9694: 15620 | 15624 | 15635 | 15875