Attachment 156277 Details for Bug 34886 – Bug 34886: Restore 'Place reserve' prior to session

[patch] Bug 34886: Restore 'Place reserve' prior to session

Bug-34886-Restore-Place-reserve-prior-to-session.patch (text/plain), 1.64 KB, created by Martin Renvoize (ashimema) on 2023-09-27 10:20:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-09-27 10:20:49 UTC

Size: 1.64 KB

patch

obsolete

>From f13c249bb9f37b8cd18c16bef7e6a8ca3467bcbc Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 22 Sep 2023 16:16:09 +0100
>Subject: [PATCH] Bug 34886: Restore 'Place reserve' prior to session
>
>This is a pragmatic patch to restore the display of 'Place hold' prior
>to patron login. When we have no Patron, we fall back to only checkout
>get_onshelfholds_policy without a patron. When we have a patron, we use
>IsAvailableForItemLevelRequest instead to get the more detailed
>response.
>
>This isn't perfect, but I can't see an easy way to restore this
>functionality otherwise.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> opac/opac-detail.pl | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index 5f5ce3013a7..2483e557721 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -682,7 +682,12 @@ else {
>         $item_info->{holding_library_info} = $opac_info_holding->content if $opac_info_holding;
>         $item_info->{home_library_info} = $opac_info_home->content if $opac_info_home;
> 
>-        $can_item_be_reserved = $can_item_be_reserved || $patron && IsAvailableForItemLevelRequest($item, $patron, undef);
>+        if ( $patron ) {
>+            $can_item_be_reserved = IsAvailableForItemLevelRequest($item, $patron, undef);
>+        } else {
>+            $can_item_be_reserved =
>+                Koha::CirculationRules->get_onshelfholds_policy( { item => $item, patron => undef } );
>+        }
> 
>         # get collection code description, too
>         my $ccode = $item->ccode;
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 34886: 156107 | 156114 | 156150 | 156151 | 156152 | 156153 | 156277 | 156278 | 156279 | 156293 | 156294 | 156295 | 156326 | 156327 | 156980 | 156981 | 159678 | 159679 | 161633 | 161634 | 161981 | 161982 | 163674 | 164106 | 164107 | 164108 | 164109 | 164110 | 164159 | 164160 | 164161