Attachment 156334 Details for Bug 9525 – Bug 9525: (QA follow-up) Fix QA complaints

[patch] Bug 9525: (QA follow-up) Fix QA complaints

Bug-9525-QA-follow-up-Fix-QA-complaints.patch (text/plain), 2.12 KB, created by Nick Clemens (kidclamp) on 2023-09-28 14:12:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-09-28 14:12:12 UTC

Size: 2.12 KB

patch

obsolete

>From ba478958bb4f2418665afb1ce20ccb7c3b8bc077 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 26 Apr 2023 15:02:54 +0000
>Subject: [PATCH] Bug 9525: (QA follow-up) Fix QA complaints
>
>Add boolean to schema
>Remove stray console.log
>Fix subroutine name in POD
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/Library.pm                                                 | 2 +-
> Koha/Schema/Result/LibraryGroup.pm                              | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt | 1 -
> 3 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Library.pm b/Koha/Library.pm
>index 7af8868da5..ff93d8a8da 100644
>--- a/Koha/Library.pm
>+++ b/Koha/Library.pm
>@@ -376,7 +376,7 @@ sub opac_info {
>     });
> }
> 
>-=head3 get_float_group_libraries
>+=head3 get_float_libraries
> 
> Return all libraries belonging to the same float group
> 
>diff --git a/Koha/Schema/Result/LibraryGroup.pm b/Koha/Schema/Result/LibraryGroup.pm
>index 43120c92d5..7714f766dd 100644
>--- a/Koha/Schema/Result/LibraryGroup.pm
>+++ b/Koha/Schema/Result/LibraryGroup.pm
>@@ -282,6 +282,7 @@ __PACKAGE__->add_columns(
>     '+ft_search_groups_staff' => { is_boolean => 1 },
>     '+ft_local_hold_group'    => { is_boolean => 1 },
>     '+ft_limit_item_editing'  => { is_boolean => 1 },
>+    '+ft_local_float_group'   => { is_boolean => 1 },
> );
> 
> 1;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>index fc081aa8f7..b41d2062c4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>@@ -373,7 +373,6 @@
>             $('#edit-group-modal-id').val( id );
>             $('#edit-group-modal-title').val( title );
>             $('#edit-group-modal-description').val( description );
>-            console.log(ft_local_float_group);
>             if ( parent_id ) {
>                 $('#edit-group-modal-ft_hide_patron_info').prop('checked', false);
>                 $('#edit-group-modal-ft_limit_item_editing').prop('checked', false);
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 9525: 40077 | 40102 | 40103 | 44754 | 44756 | 44760 | 48310 | 100420 | 100421 | 100422 | 100741 | 100742 | 100743 | 103828 | 103829 | 103830 | 103831 | 112550 | 112551 | 112552 | 112553 | 124825 | 124826 | 124827 | 133071 | 133072 | 133073 | 139024 | 139025 | 139026 | 143740 | 143741 | 143742 | 143743 | 150241 | 150242 | 150243 | 150244 | 150245 | 150246 | 156330 | 156331 | 156332 | 156333 | 156334 | 156335 | 156336