Bugzilla – Attachment 156361 Details for
Bug 34836
OPAC ISBD or MARC view blows up with error 500
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34836: Add patron check to isbd and marc detail pages
Bug-34836-Add-patron-check-to-isbd-and-marc-detail.patch (text/plain), 2.06 KB, created by
Marcel de Rooy
on 2023-09-29 06:12:16 UTC
(
hide
)
Description:
Bug 34836: Add patron check to isbd and marc detail pages
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-09-29 06:12:16 UTC
Size:
2.06 KB
patch
obsolete
>From 0d4eeea83dfd220caf32f660552cb9d619e5c8d4 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 25 Sep 2023 10:21:36 +0000 >Subject: [PATCH] Bug 34836: Add patron check to isbd and marc detail pages >Content-Type: text/plain; charset=utf-8 > >Test plan: >- Go to circulation rules and set On shelf holds allowed to If all unavailable >- Log out >- Visit a MARC detail or ISBD detail bib record on OPAC: >http://localhost:8080/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=76 >http://localhost:8080/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=76 >- Notice it blows up with error 500, on both occasions >- Apply patch. Repeat. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > opac/opac-ISBDdetail.pl | 2 +- > opac/opac-MARCdetail.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl >index fb7fc05bf5..86685f9239 100755 >--- a/opac/opac-ISBDdetail.pl >+++ b/opac/opac-ISBDdetail.pl >@@ -178,7 +178,7 @@ my $res = GetISBDView({ > my $items = $biblio->items; > while ( my $item = $items->next ) { > >- $can_item_be_reserved = $can_item_be_reserved || IsAvailableForItemLevelRequest($item, $patron, undef); >+ $can_item_be_reserved = $can_item_be_reserved || $patron && IsAvailableForItemLevelRequest( $item, $patron, undef ); > } > > if( $can_item_be_reserved || CountItemsIssued($biblionumber) || $biblio->has_items_waiting_or_intransit ) { >diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl >index c42d73abf0..9b85bbbe1e 100755 >--- a/opac/opac-MARCdetail.pl >+++ b/opac/opac-MARCdetail.pl >@@ -140,7 +140,7 @@ my $can_item_be_reserved = 0; > $items->reset; > > while ( my $item = $items->next ) { >- $can_item_be_reserved = $can_item_be_reserved || IsAvailableForItemLevelRequest($item, $patron, undef); >+ $can_item_be_reserved = $can_item_be_reserved || $patron && IsAvailableForItemLevelRequest( $item, $patron, undef ); > } > > if( $can_item_be_reserved || CountItemsIssued($biblionumber) || $biblio->has_items_waiting_or_intransit ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34836
:
156146
|
156303
| 156361