Bugzilla – Attachment 156381 Details for
Bug 34916
ArticleRequests.t may fail on wrong borrowernumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34916: Fix wrong borrowernumber in ArticleRequests.t
Bug-34916-Fix-wrong-borrowernumber-in-ArticleReque.patch (text/plain), 1.34 KB, created by
Katrin Fischer
on 2023-09-29 11:32:42 UTC
(
hide
)
Description:
Bug 34916: Fix wrong borrowernumber in ArticleRequests.t
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-09-29 11:32:42 UTC
Size:
1.34 KB
patch
obsolete
>From f1f1649fc72f07b5fa012486b6d5d875f1401684 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 26 Sep 2023 13:45:35 +0000 >Subject: [PATCH] Bug 34916: Fix wrong borrowernumber in ArticleRequests.t > >Simple fix: Send patron to userenv instead of library only. > >Test plan: >Do not apply patch. >Remove borrowernumber 51. >Run t/db_dependent/Koha/ArticleRequests.t. (FAIL) >Apply patch, rerun test (PASS) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > t/db_dependent/Koha/ArticleRequests.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/ArticleRequests.t b/t/db_dependent/Koha/ArticleRequests.t >index 98b92a3d40..1b240b6524 100755 >--- a/t/db_dependent/Koha/ArticleRequests.t >+++ b/t/db_dependent/Koha/ArticleRequests.t >@@ -40,7 +40,7 @@ subtest 'requested() tests' => sub { > my $library_2 = $builder->build_object( { class => 'Koha::Libraries' } ); > > my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library_1->id, flags => 1 } } ); >- t::lib::Mocks::mock_userenv( { branchcode => $library_1 } ); >+ t::lib::Mocks::mock_userenv( { patron => $patron } ); > > # FIXME: we moved past this pattern. This method should be refactored > # as ->filter_by_requested >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34916
:
156227
| 156381