Bugzilla – Attachment 156403 Details for
Bug 29145
Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29145: (QA follow-up) Fix tests removing 'unblessed'
Bug-29145-QA-follow-up-Fix-tests-removing-unblesse.patch (text/plain), 2.79 KB, created by
Katrin Fischer
on 2023-09-29 14:08:09 UTC
(
hide
)
Description:
Bug 29145: (QA follow-up) Fix tests removing 'unblessed'
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-09-29 14:08:09 UTC
Size:
2.79 KB
patch
obsolete
>From a0bbc89ab4e3e57f412a7b27f18eeb80c04ea3be Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Fri, 29 Sep 2023 13:49:47 +0000 >Subject: [PATCH] Bug 29145: (QA follow-up) Fix tests removing 'unblessed' > >This fixes issues with the tests caused by: >Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm >--- > t/db_dependent/Circulation/MarkIssueReturned.t | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Circulation/MarkIssueReturned.t b/t/db_dependent/Circulation/MarkIssueReturned.t >index 57b9820857..9c43132a25 100755 >--- a/t/db_dependent/Circulation/MarkIssueReturned.t >+++ b/t/db_dependent/Circulation/MarkIssueReturned.t >@@ -203,7 +203,7 @@ subtest 'AutoRemoveOverduesRestrictions' => sub { > my $item_1 = $builder->build_sample_item; > my $item_2 = $builder->build_sample_item; > my $item_3 = $builder->build_sample_item; >- my $nine_days_ago = dt_from_string->subtract( days => 9 ); >+ my $nine_days_ago = dt_from_string->subtract( days => 9 ); > my $checkout_1 = > AddIssue( $patron, $item_1->barcode, $nine_days_ago ); # overdue, but would not trigger debarment > my $checkout_2 = >@@ -234,9 +234,9 @@ subtest 'AutoRemoveOverduesRestrictions' => sub { > > my $ten_days_ago = dt_from_string->subtract( days => 10 ); > >- $checkout_1 = AddIssue( $patron->unblessed, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment >+ $checkout_1 = AddIssue( $patron, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment > $checkout_2 = >- AddIssue( $patron->unblessed, $item_2->barcode, $nine_days_ago ); # overdue, but would not trigger debarment >+ AddIssue( $patron, $item_2->barcode, $nine_days_ago ); # overdue, but would not trigger debarment > > Koha::Patron::Debarments::AddUniqueDebarment( > { >@@ -254,7 +254,7 @@ subtest 'AutoRemoveOverduesRestrictions' => sub { > 'OVERDUES debarment is removed if remaining items would not result in patron debarment' > ); > >- $checkout_1 = AddIssue( $patron->unblessed, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment >+ $checkout_1 = AddIssue( $patron, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment > > Koha::Patron::Debarments::AddUniqueDebarment( > { >@@ -275,7 +275,7 @@ subtest 'AutoRemoveOverduesRestrictions' => sub { > my $eleven_days_ago = dt_from_string->subtract( days => 11 ); > > # overdue and would trigger debarment >- $checkout_2 = AddIssue( $patron->unblessed, $item_2->barcode, $eleven_days_ago ); >+ $checkout_2 = AddIssue( $patron, $item_2->barcode, $eleven_days_ago ); > > # $checkout_1 should now not trigger debarment with this new rule for specific branchcode > $dbh->do( >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29145
:
125495
|
140819
|
140820
|
141822
|
141823
|
142394
|
142395
|
142396
|
142814
|
142815
|
142816
|
142817
|
143213
|
144773
|
144774
|
144775
|
144776
|
144777
|
144778
|
144779
|
144780
|
144781
|
144782
|
145720
|
145749
|
145750
|
145751
|
153804
|
153805
|
153806
|
153807
|
153808
|
153809
|
153810
|
153811
|
153812
|
153813
|
153814
|
156392
|
156393
|
156394
|
156395
|
156396
|
156397
|
156398
|
156399
|
156400
|
156401
|
156402
| 156403 |
156404