Bugzilla – Attachment 156429 Details for
Bug 30556
OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30556: Fix the call on IsAvailableForItemLevelRequest and CanBookBeReserved
Bug-30556-Fix-the-call-on-IsAvailableForItemLevelR.patch (text/plain), 2.76 KB, created by
Hammat wele
on 2023-09-30 00:25:48 UTC
(
hide
)
Description:
Bug 30556: Fix the call on IsAvailableForItemLevelRequest and CanBookBeReserved
Filename:
MIME Type:
Creator:
Hammat wele
Created:
2023-09-30 00:25:48 UTC
Size:
2.76 KB
patch
obsolete
>From bd31626ef2ecbfcefb4f7b2908c9142a6baf29f1 Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Sat, 30 Sep 2023 00:08:54 +0000 >Subject: [PATCH] Bug 30556: Fix the call on IsAvailableForItemLevelRequest and > CanBookBeReserved > >--- > opac/opac-ISBDdetail.pl | 4 ++-- > opac/opac-MARCdetail.pl | 4 ++-- > opac/opac-detail.pl | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl >index 3f9446583a..6e4906eec6 100755 >--- a/opac/opac-ISBDdetail.pl >+++ b/opac/opac-ISBDdetail.pl >@@ -179,11 +179,11 @@ my $res = GetISBDView({ > my $items = $biblio->items; > while ( my $item = $items->next ) { > >- $is_available = IsAvailableForItemLevelRequest($item, $patron, $currentbranch) >+ $is_available = IsAvailableForItemLevelRequest($item, $patron, undef) > unless $is_available; > } > >-my $canReserve = CanBookBeReserved($loggedinuser, $biblionumber, $currentbranch); >+my $canReserve = CanBookBeReserved($loggedinuser, $biblionumber, undef); > if (!$loggedinuser || ($canReserve->{status} eq "OK" && $is_available)) { > $template->param( ReservableItems => 1 ); > } >diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl >index 089d978ca5..eaab1f1b94 100755 >--- a/opac/opac-MARCdetail.pl >+++ b/opac/opac-MARCdetail.pl >@@ -141,11 +141,11 @@ my $is_available; > $items->reset; > > while ( my $item = $items->next ) { >- $is_available = IsAvailableForItemLevelRequest($item, $patron, $currentbranch) >+ $is_available = IsAvailableForItemLevelRequest($item, $patron, undef) > unless $is_available; > } > >-my $canReserve = CanBookBeReserved($loggedinuser, $biblionumber, $currentbranch); >+my $canReserve = CanBookBeReserved($loggedinuser, $biblionumber, undef); > if (!$loggedinuser || ($canReserve->{status} eq "OK" && $is_available)) { > $template->param( ReservableItems => 1 ); > } >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index f1230290af..dd521e0ace 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -682,7 +682,7 @@ else { > $item_info->{holding_library_info} = $opac_info_holding->content if $opac_info_holding; > $item_info->{home_library_info} = $opac_info_home->content if $opac_info_home; > >- $is_available = IsAvailableForItemLevelRequest($item, $patron, $currentbranch) >+ $is_available = IsAvailableForItemLevelRequest($item, $patron, undef) > unless $is_available; > > # get collection code description, too >@@ -759,7 +759,7 @@ else { > } > } > >-my $canReserve = CanBookBeReserved($borrowernumber, $biblionumber, $currentbranch); >+my $canReserve = CanBookBeReserved($borrowernumber, $biblionumber, undef); > if (!$borrowernumber || ($canReserve->{status} eq "OK" && $is_available)) { > $template->param( ReservableItems => 1 ); > } >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30556
:
133497
|
133608
|
134172
|
134420
|
134421
|
134436
|
134437
|
134438
|
134617
|
134619
|
134620
|
134621
|
135395
|
137065
|
139289
|
139290
|
139291
|
139292
|
144429
|
147378
|
147379
|
147380
|
147381
|
147382
|
147441
|
147442
|
150218
|
150219
|
150220
|
150221
|
150222
|
156188
|
156189
|
156190
|
156191
|
156192
|
156429
|
157087
|
157088
|
157089
|
157090
|
157091