Attachment 156436 Details for Bug 34968 – Bug 34968: Remove unneeded module from Search.t

[patch] Bug 34968: Remove unneeded module from Search.t

Bug-34968-Remove-unneeded-module-from-Searcht.patch (text/plain), 1.52 KB, created by Marcel de Rooy on 2023-09-30 06:44:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-09-30 06:44:08 UTC

Size: 1.52 KB

patch

obsolete

>From c6820f2951a9daba8775a6ef5a66e3dc09c5c800 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Sat, 30 Sep 2023 06:40:50 +0000
>Subject: [PATCH] Bug 34968: Remove unneeded module from Search.t
>Content-Type: text/plain; charset=utf-8
>
>Test::DBIx::Class is not even used here.
>Just like C4::Biblio.
>We should remove TestBuilder too (this is t not t/db)!
>
>Test plan:
>Run t/Search.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/Search.t | 23 ++---------------------
> 1 file changed, 2 insertions(+), 21 deletions(-)
>
>diff --git a/t/Search.t b/t/Search.t
>index a6fed41af3..e32fc85595 100755
>--- a/t/Search.t
>+++ b/t/Search.t
>@@ -17,29 +17,12 @@
> 
> use Modern::Perl;
> 
>-use C4::Biblio;
>-use Test::More;
>+use Test::More tests => 2;
> use Test::MockModule;
> use Test::Warn;
> use t::lib::Mocks;
>-use t::lib::TestBuilder;
> 
>-use Module::Load::Conditional qw/check_install/;
>-
>-BEGIN {
>-    if ( check_install( module => 'Test::DBIx::Class' ) ) {
>-        plan tests => 4;
>-    } else {
>-        plan skip_all => "Need Test::DBIx::Class"
>-    }
>-}
>-
>-# Mock the DB connexion and C4::Context
>-use Test::DBIx::Class;
>-
>-use_ok('C4::Search');
>-can_ok('C4::Search',
>-    qw/_build_initial_query/);
>+use C4::Search;
> 
> subtest "_build_initial_query tests" => sub {
> 
>@@ -187,8 +170,6 @@ subtest "searchResults PassItemMarcToXSLT test" => sub {
>         return;
>     });
> 
>-    my $builder = t::lib::TestBuilder->new;
>-
>     my $xml_record = q{
> <record
>     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34968: 156436 | 156503