Attachment 156449 Details for Bug 34873 – Bug 34873: Fix inconsistencies between "Sending your cart/list" headings

[patch] Bug 34873: Fix inconsistencies between "Sending your cart/list" headings

Bug-34873-Fix-inconsistencies-between-Sending-your.patch (text/plain), 2.60 KB, created by David Nind on 2023-10-01 20:44:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-10-01 20:44:23 UTC

Size: 2.60 KB

patch

obsolete

>From f8e92fa38fc2e86a20b762da6535f848c7e99a21 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 22 Sep 2023 18:33:36 +0000
>Subject: [PATCH] Bug 34873: Fix inconsistencies between "Sending your
> cart/list" headings
>
>This patch modifies the templates for the popup windows which are shown
>when you send a cart or a list via email in the staff interface.
>
>To test, apply the patch and log into the staff interface.
>
>- Perform a catalog search which will return results.
>- Select one or more results and add them to the cart.
>- Click the cart icon in the header menu to open the Cart popup.
>- Click "Send". Compare this pop-up window to the version shown when
>  sending a list:
>
>- Open the Lists page and view the contents of a list.
>- Click the "Send list" button in the toolbar.
>- This popup should look correct and be consistent with the Cart
>  version.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/basket/sendbasketform.tt   | 4 ++--
> .../prog/en/modules/virtualshelves/sendshelfform.tt          | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt
>index a867f96782..908e30418b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt
>@@ -32,9 +32,9 @@
> 
> [% INCLUDE 'blocking_errors.inc' %]
> <form action="/cgi-bin/koha/basket/sendbasket.pl" method="post">
>-
>+<h1>Sending your cart</h1>
> <fieldset class="rows"> 
>-<legend>Sending your cart</legend>
>+<legend class="sr-only">Enter message details</legend>
> <ol>   <li>
>         <label for="email_add">Email address:</label>
>         <input type="text" id="email_add" name="email_add" size="43" class="focus" />
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelfform.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelfform.tt
>index cd4462c0eb..0989c28a9d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelfform.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelfform.tt
>@@ -32,8 +32,9 @@
> 
> <form action="/cgi-bin/koha/virtualshelves/sendshelf.pl" method="post">
> 
>-<fieldset class="rows"> 
>-    <legend><h1>Sending your list</h1></legend>
>+<h1>Sending your list</h1>
>+<fieldset class="rows">
>+    <legend class="sr-only">Enter message details</legend>
> <ol>   <li>
>         <label for="email">Email address:</label>
>         <input type="text" id="email" name="email" size="43" class="focus" />
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34873: 156377 | 156449 | 156450 | 156678