Attachment 156458 Details for Bug 34390 – Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header

[patch] Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header

Bug-34390-Fix-inconsistencies-in-credit-types-titl.patch (text/plain), 2.69 KB, created by Owen Leonard on 2023-10-02 16:00:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-10-02 16:00:29 UTC

Size: 2.69 KB

patch

obsolete

>From 23899e1e91fe70a253ad4cdba1f315a56ba6b3e4 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 2 Oct 2023 15:59:08 +0000
>Subject: [PATCH] Bug 34390:  Fix inconsistencies in credit types titles,
> breadcrumbs, and header
>
>Fix inconsistencies in credit types titles, breadcrumbs, and header
>
>This patch fixes a couple of inconsistencies in the credit types
>administration page, making sure the page title, breadcrumb
>navigation, and page headers are consistent with each other.
>
>To test, apply the patch and go to Administration -> Credit types. Test
>each variation of the page:
>
>- Main page
>- New credit type
>- Modify credit type
>---
> .../intranet-tmpl/prog/en/modules/admin/credit_types.tt   | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt
>index bba0dcb8b1..f4e957394c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt
>@@ -8,7 +8,7 @@
> <title>[% FILTER collapse %]
>     [% IF op =='add_form' %]
>        [% IF credit_type.code %]
>-           [% t("Modify credit type") | html %] &rsaquo;
>+           [% tx("Modify credit type {credit_type}", {credit_type = credit_type.code }) | html %] &rsaquo;
>        [% ELSE %]
>            [% t("New credit type") | html %] &rsaquo;
>        [% END %]
>@@ -39,7 +39,7 @@
>             [% END %]
>             [% WRAPPER breadcrumb_item bc_active= 1 %]
>                 [% IF credit_type.code %]
>-                    <span>Modify credit type</span>
>+                    [% tx("Modify credit type {credit_type}", {credit_type = credit_type.code }) | html %]
>                 [% ELSE %]
>                     <span>New credit type</span>
>                 [% END %]
>@@ -77,7 +77,7 @@
> 
>                 [% IF op == 'add_form' %]
>                     [% IF credit_type %]
>-                        <h1>Modify a credit type</h1>
>+                        <h1>[% tx("Modify credit type {credit_type}", {credit_type = credit_type.code }) | html %]</h1>
>                     [% ELSE %]
>                         <h1>New credit type</h1>
>                     [% END %]
>@@ -155,7 +155,7 @@
>                         <a class="btn btn-default" id="newcredittype" href="/cgi-bin/koha/admin/credit_types.pl?op=add_form"><i class="fa fa-plus"></i> New credit type</a>
>                     </div>
> 
>-                    <h1>Account credit types</h1>
>+                    <h1>Credit types</h1>
>                     [% IF credit_types.count %]
>                         <div class="page-section">
>                             <table id="table_credit_types">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34390: 156458 | 156467 | 156468 | 156496 | 156497 | 156676 | 156677