Attachment 156491 Details for Bug 34969 – Bug 34969: Remove unneeded module from buildQuery.t

[patch] Bug 34969: Remove unneeded module from buildQuery.t

Bug-34969-Remove-unneeded-module-from-buildQueryt.patch (text/plain), 1.35 KB, created by Katrin Fischer on 2023-10-03 10:16:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-10-03 10:16:37 UTC

Size: 1.35 KB

patch

obsolete

>From a6a4727ed009739852f6cc4c094edf80e82de317 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Sat, 30 Sep 2023 06:52:08 +0000
>Subject: [PATCH] Bug 34969: Remove unneeded module from buildQuery.t
>
>Test plan:
>Run t/Search/buildQuery.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> t/Search/buildQuery.t | 21 +++------------------
> 1 file changed, 3 insertions(+), 18 deletions(-)
>
>diff --git a/t/Search/buildQuery.t b/t/Search/buildQuery.t
>index 58d8158f96..d03b2cf8b0 100755
>--- a/t/Search/buildQuery.t
>+++ b/t/Search/buildQuery.t
>@@ -16,27 +16,12 @@
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>+use Test::More tests => 9;
>+use Net::Z3950::ZOOM;
> 
>-use Test::More;
> use t::lib::Mocks;
> 
>-use Module::Load::Conditional qw/check_install/;
>-
>-BEGIN {
>-    if ( check_install( module => 'Test::DBIx::Class' ) ) {
>-        plan tests => 12;
>-    } else {
>-        plan skip_all => "Need Test::DBIx::Class"
>-    }
>-}
>-
>-# Mock the DB connection and C4::Context
>-use Test::DBIx::Class;
>-
>-use_ok('C4::Search', qw( buildQuery ));
>-can_ok('C4::Search',
>-    qw/buildQuery/);
>-use_ok("Net::Z3950::ZOOM");
>+use C4::Search qw( buildQuery  );
> 
> #FIXME: would it be better to use our real ccl.properties file?
> sub _get_ccl_properties {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34969: 156437 | 156491 | 156492