Attachment 156492 Details for Bug 34969 – Bug 34969: (QA follow-up) Re-add removed use_ok and can_ok tests

[patch] Bug 34969: (QA follow-up) Re-add removed use_ok and can_ok tests

Bug-34969-QA-follow-up-Re-add-removed-useok-and-ca.patch (text/plain), 1.09 KB, created by Katrin Fischer on 2023-10-03 10:16:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-10-03 10:16:42 UTC

Size: 1.09 KB

patch

obsolete

>From 4152cfbd7880918893dcb7ecdad99f7d9c282876 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Tue, 3 Oct 2023 10:14:51 +0000
>Subject: [PATCH] Bug 34969: (QA follow-up) Re-add removed use_ok and can_ok
> tests
>
>No need to remove them for removing Test::DBIx::Class dependency.
>Tests still pass.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> t/Search/buildQuery.t | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/t/Search/buildQuery.t b/t/Search/buildQuery.t
>index d03b2cf8b0..2832bc9fea 100755
>--- a/t/Search/buildQuery.t
>+++ b/t/Search/buildQuery.t
>@@ -16,13 +16,20 @@
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-use Test::More tests => 9;
>+use Test::More tests => 12;
> use Net::Z3950::ZOOM;
> 
> use t::lib::Mocks;
> 
> use C4::Search qw( buildQuery  );
> 
>+use_ok( 'C4::Search', qw( buildQuery ) );
>+can_ok(
>+    'C4::Search',
>+    qw/buildQuery/
>+);
>+use_ok("Net::Z3950::ZOOM");
>+
> #FIXME: would it be better to use our real ccl.properties file?
> sub _get_ccl_properties {
>     my $config = q(
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34969: 156437 | 156491 | 156492