Attachment 156499 Details for Bug 34820 – Bug 34820: Clarify inventory tool message for items with non-matching notforloan value

[patch] Bug 34820: Clarify inventory tool message for items with non-matching notforloan value

Bug-34820-Clarify-inventory-tool-message-for-items.patch (text/plain), 2.63 KB, created by Katrin Fischer on 2023-10-03 12:35:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-10-03 12:35:45 UTC

Size: 2.63 KB

patch

obsolete

>From 1e605bfc41b53d88bb0e96d3f1bc26eb2718bd1c Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 18 Sep 2023 12:02:34 -0400
>Subject: [PATCH] Bug 34820: Clarify inventory tool message for items with
> non-matching notforloan value
>
>In the inventory tool, if one or more not for loan values are selected, and an item is scanned that has no NFL status or an unselected NFL status, the error message reads "Unknown not-for-loan status". This can be interpreted as the item having an NFL status value that is not defined in the system, but that is not accurate. This should be reworded to remove ambiguity.
>
>Test plan:
>1) Create two items, one of which has the NFL status of "Ordered", the
> other having no NFL status
>2) Enter those two barcodes in the inventory tool barcodes list
>3) Check only "Ordered" in items.notforloan
>4) Note the problem messages
>5) Apply this patch
>6) Re-run the inventory tool
>7) Note the new clarified messages!
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>index a430a3fc24..f7c4084a6b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>@@ -149,6 +149,7 @@
> 
> <fieldset class="rows" id="optionalfilters">
> <legend>Optional filters for inventory list or comparing barcodes</legend>
>+ Scanned items are expected to match one of the selected not for loan critera if any are checked.
> 
> <div id="statuses" style="display: block;">
> [% FOREACH status IN statuses %]
>@@ -311,7 +312,11 @@
> [% IF problem.key == 'wrongplace' %]
> Found in wrong place 
> [% ELSIF problem.key == 'changestatus' %]
>- Unknown not-for-loan status 
>+ [% IF result.notforloan %]
>+ Item has unselected Not for loan status [% result.notforloan %] 
>+ [% ELSE %]
>+ Items has no not for loan status 
>+ [% END %]
> [% ELSIF problem.key == 'not_scanned' %]
> Missing (not scanned) 
> [% ELSIF problem.key == 'checkedout' %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34820: 155838 | 155848 | 155849 | 155871 | 155928 | 155957 | 156499 | 156500 | 156501 | 156502