Attachment 156500 Details for Bug 34820 – Bug 34820: (QA follow-up) add filter, update CSV output

[patch] Bug 34820: (QA follow-up) add filter, update CSV output

Bug-34820-QA-follow-up-add-filter-update-CSV-outpu.patch (text/plain), 2.54 KB, created by Katrin Fischer on 2023-10-03 12:35:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-10-03 12:35:47 UTC

Size: 2.54 KB

patch

obsolete

>From 9790527086574fd69a1e03e62bac33b820ca46b7 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 20 Sep 2023 06:40:08 -0400
>Subject: [PATCH] Bug 34820: (QA follow-up) add filter, update CSV output
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 4 ++--
> tools/inventory.pl | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>index f7c4084a6b..1937604441 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>@@ -149,7 +149,7 @@
> 
> <fieldset class="rows" id="optionalfilters">
> <legend>Optional filters for inventory list or comparing barcodes</legend>
>- Scanned items are expected to match one of the selected not for loan critera if any are checked.
>+ Scanned items are expected to match one of the selected not for loan criteria if any are checked.
> 
> <div id="statuses" style="display: block;">
> [% FOREACH status IN statuses %]
>@@ -313,7 +313,7 @@
> Found in wrong place 
> [% ELSIF problem.key == 'changestatus' %]
> [% IF result.notforloan %]
>- Item has unselected Not for loan status [% result.notforloan %] 
>+ Item has unselected Not for loan status [% result.notforloan | html %] 
> [% ELSE %]
> Items has no not for loan status 
> [% END %]
>diff --git a/tools/inventory.pl b/tools/inventory.pl
>index ca52b8faba..65f261feb7 100755
>--- a/tools/inventory.pl
>+++ b/tools/inventory.pl
>@@ -411,7 +411,7 @@ if (defined $input->param('CSVexport') && $input->param('CSVexport') eq 'on'){
> if( $key eq 'wrongplace' ) {
> $errstr .= "wrong place,";
> } elsif( $key eq 'changestatus' ) {
>- $errstr .= "unknown notforloan status,";
>+ $errstr .= "unselected notforloan status $item->{notforloan},";
> } elsif( $key eq 'not_scanned' ) {
> $errstr .= "missing,";
> } elsif( $key eq 'no_barcode' ) {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34820: 155838 | 155848 | 155849 | 155871 | 155928 | 155957 | 156499 | 156500 | 156501 | 156502