Attachment 156571 Details for Bug 34557 – Bug 34557: (follow-up) Make link more like button in staff interface

[patch] Bug 34557: (follow-up) Make link more like button in staff interface

Bug-34557-follow-up-Make-link-more-like-button-in-.patch (text/plain), 3.03 KB, created by Owen Leonard on 2023-10-05 11:33:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-10-05 11:33:57 UTC

Size: 3.03 KB

patch

obsolete

>From 0ec26705e8d3d0b1e237f3abd0ffccd721baf889 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 18 Aug 2023 07:02:24 +0000
>Subject: [PATCH] Bug 34557: (follow-up) Make link more like button in staff
> interface
>
>This patch adds Bootstrap button style to the link and changes the text
>from "Load your checkouts" to "Show your checkouts."
>
>The patch adds an anchor to the link so that the browser jumps down the
>page a bit making the checkouts more visible.
>
>The patch also corrects the includes for Font Awesome files. No icons
>were loading because of incorrect asset links.
>
>To test, follow the previous patch's test plan, checking that the button
>looks correctly styled and that the page reloads with the checkout form
>at the top.
>
>Confirm that Font Awesome icons are loading throughout the page.
>
>Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>index c0f34ab8e2..e059b83293 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>@@ -14,7 +14,9 @@
> [% ELSE %]
> <link rel="shortcut icon" href="[% interface | html %]/[% theme | html %]/images/favicon.ico" type="image/x-icon" />
> [% END %]
>-[% Asset.css("lib/font-awesome/css/font-awesome.min.css") | $raw %]
>+[% Asset.css("lib/fontawesome/css/fontawesome.min.css") | $raw %]
>+[% Asset.css("lib/fontawesome/css/brands.min.css") | $raw %]
>+[% Asset.css("lib/fontawesome/css/solid.min.css") | $raw %]
> [% IF ( bidi ) %]
>     [% Asset.css("css/sco-rtl.css") | $raw %]
> [% ELSE %]
>@@ -294,7 +296,7 @@
>                         <li class="nav-item" role="presentation">
>                             <a class="nav-link" href="#holds-tab" id="holds" aria-controls="home" aria-selected="false" data-toggle="tab">
>                                 [% IF waiting_holds_count %]
>-                                    <i class="fa fa-exclamation" aria-hidden="true"></i>
>+                                    <i class="fa fa-exclamation-circle" aria-hidden="true"></i>
>                                 [% END %]
>                                 Holds ([% HOLDS.count | html %])
>                             </a>
>@@ -409,7 +411,7 @@
>                                         </tbody>
>                                     </table>
>                                     [% ELSE %]
>-                                        <a href="?load_checkouts=1">Load your checkouts</a>
>+                                        <a class="btn btn-secondary" href="?load_checkouts=1#scan_form"><i class="fa fa-book" aria-hidden="true"></i> Show your checkouts</a>
>                                     [% END # / IF ( Koha.preference('SCOLoadCheckoutsByDefault') || load_checkouts ) %]
>                                 [% ELSE %]
>                                     <h3>You currently have nothing checked out.</h3>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34557: 154508 | 154544 | 154587 | 154590 | 154591 | 156570 | 156571 | 158368 | 158369 | 158370 | 158377 | 158378 | 158379