Attachment 156665 Details for Bug 30708 – Bug 30708: Fix Trains.ts tests

[patch] Bug 30708: Fix Trains.ts tests

Bug-30708-Fix-Trainsts-tests.patch (text/plain), 4.77 KB, created by Marcel de Rooy on 2023-10-07 06:41:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-10-07 06:41:35 UTC

Size: 4.77 KB

patch

obsolete

>From 01fc57462e58896de28a4c302a258b53bcc164ec Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 19 Jun 2023 11:36:21 +0200
>Subject: [PATCH] Bug 30708: Fix Trains.ts tests
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: BULAC - http://www.bulac.fr/
>Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov>
>Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/cypress/integration/Preservation/Trains.ts | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
>diff --git a/t/cypress/integration/Preservation/Trains.ts b/t/cypress/integration/Preservation/Trains.ts
>index 858d523ebd..7c2a440fb7 100644
>--- a/t/cypress/integration/Preservation/Trains.ts
>+++ b/t/cypress/integration/Preservation/Trains.ts
>@@ -50,11 +50,13 @@ function get_processings() {
>             name: "new processing",
>             processing_id: 1,
>             attributes: get_attributes(),
>+            letter_code: null,
>         },
>         {
>             name: "an other processing",
>             processing_id: 2,
>             attributes: get_other_attributes(),
>+            letter_code: null,
>         },
>     ];
> }
>@@ -98,28 +100,33 @@ function get_train_items() {
>             processing_attribute_id:
>                 processing_attributes[0].processing_attribute_id,
>             value: "Argentina",
>+            _strings: { value: { str: "Argentina" } },
>         },
>         {
>             processing_attribute: processing_attributes[0],
>             processing_attribute_id:
>                 processing_attributes[0].processing_attribute_id,
>             value: "Not a country",
>+            _strings: { value: { str: "Not a country" } },
>         },
>         {
>             processing_attribute: processing_attributes[1],
>             processing_attribute_id:
>                 processing_attributes[1].processing_attribute_id,
>             value: "a biblio title modified",
>+            _strings: { value: { str: "a biblio title modified" } },
>         },
>         {
>             processing_attribute: processing_attributes[2],
>             processing_attribute_id:
>                 processing_attributes[2].processing_attribute_id,
>             value: "12cm",
>+            _strings: { value: { str: "12cm" } },
>         },
>     ];
>     train_item_1.added_on = "2023-03-31T12:23:34+00:00";
>     train_item_1.processing_id = 1;
>+    train_item_1.processing = get_processings()[0];
>     train_item_1.item_id = 1;
> 
>     let train_item_2 = get_items()[1];
>@@ -130,22 +137,26 @@ function get_train_items() {
>             processing_attribute_id:
>                 processing_attributes[0].processing_attribute_id,
>             value: "Uruguay",
>+            _strings: { value: { str: "Uruguay" } },
>         },
>         {
>             processing_attribute: processing_attributes[1],
>             processing_attribute_id:
>                 processing_attributes[1].processing_attribute_id,
>             value: "an other modified title",
>+            _strings: { value: { str: "an other modified title" } },
>         },
>         {
>             processing_attribute: processing_attributes[2],
>             processing_attribute_id:
>                 processing_attributes[2].processing_attribute_id,
>             value: "34cm",
>+            _strings: { value: { str: "34cm" } },
>         },
>     ];
>     train_item_2.added_on = "2023-04-01T12:34:56+00:00";
>     train_item_2.processing_id = 1;
>+    train_item_2.processing = get_processings()[0];
>     train_item_2.item_id = 2;
> 
>     let train_item_3 = get_items()[0];
>@@ -156,16 +167,19 @@ function get_train_items() {
>             processing_attribute_id:
>                 processing_attributes[0].processing_attribute_id,
>             value: "Bolivia",
>+            _strings: { value: { str: "Bolivia" } },
>         },
>         {
>             processing_attribute: processing_attributes[1],
>             processing_attribute_id:
>                 processing_attributes[1].processing_attribute_id,
>             value: "W 123cm",
>+            _strings: { value: { str: "W 123cm" } },
>         },
>     ];
>     train_item_3.added_on = "2023-04-02T12:34:56+00:00";
>     train_item_3.processing_id = 2;
>+    train_item_3.processing = get_processings()[1];
>     train_item_3.item_id = 3;
> 
>     return [train_item_1, train_item_2, train_item_3];
>@@ -285,10 +299,10 @@ describe("Trains", () => {
>     });
> 
>     it("Add train", () => {
>-        cy.intercept("GET", "/api/v1/preservation/trains", []);
>+        cy.intercept("GET", "/api/v1/preservation/trains*", []);
>         cy.intercept(
>             "GET",
>-            "/api/v1/preservation/processings",
>+            "/api/v1/preservation/processings*",
>             get_processings()
>         );
>         cy.visit("/cgi-bin/koha/preservation/trains");
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30708: 134715 | 134716 | 134732 | 134733 | 134734 | 134736 | 134737 | 134738 | 134782 | 134783 | 134784 | 134785 | 152939 | 152940 | 152941 | 152942 | 152943 | 152944 | 152945 | 152946 | 152947 | 152948 | 152949 | 152950 | 152951 | 152952 | 152953 | 152954 | 152955 | 152956 | 152957 | 152958 | 152959 | 152960 | 152961 | 152962 | 152963 | 152964 | 152965 | 152966 | 152967 | 152968 | 152969 | 152970 | 153102 | 153576 | 154167 | 154168 | 154169 | 154170 | 154171 | 154172 | 154173 | 154174 | 154175 | 154176 | 154177 | 154178 | 154179 | 154180 | 154181 | 154182 | 154183 | 154184 | 154185 | 154186 | 154187 | 154188 | 154189 | 154190 | 154191 | 154192 | 154193 | 154194 | 154195 | 154196 | 154197 | 154198 | 154199 | 154200 | 154201 | 154202 | 154203 | 156592 | 156596 | 156597 | 156636 | 156637 | 156638 | 156639 | 156640 | 156641 | 156642 | 156643 | 156644 | 156645 | 156646 | 156647 | 156648 | 156649 | 156650 | 156651 | 156652 | 156653 | 156654 | 156655 | 156656 | 156657 | 156658 | 156659 | 156660 | 156661 | 156662 | 156663 | 156664 | 156665 | 156666 | 156667 | 156668 | 156669 | 156670 | 156671 | 156672 | 156673 | 156674 | 156675 | 157502 | 157503 | 157506 | 157508 | 157512 | 157514 | 157557