Attachment 156729 Details for Bug 35010 – Bug 35010: In record checkout history do not show anonymous patron link

[patch] Bug 35010: In record checkout history do not show anonymous patron link

Bug-35010-In-record-checkout-history-do-not-show-a.patch (text/plain), 2.25 KB, created by Owen Leonard on 2023-10-09 10:43:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-10-09 10:43:23 UTC

Size: 2.25 KB

patch

obsolete

>From e3b0007dc13f5f60d3ca22446f26db4064299480 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Sun, 8 Oct 2023 22:57:29 -1000
>Subject: [PATCH] Bug 35010: In record checkout history do not show anonymous
> patron link
>
>In a biblio record checkout history, when a checkout is anonymized the
>patron id has been replaced by anonymous patron id.
>In this case we should not show anonymous patron link.
>It looks like a real patron did this checkout.
>
>Test plan :
>1) Set an existing patron id in system preference 'AnonymousPatron'
>2) Perform anonymisation on old checkouts (or edit database manually)
>3) Look at a record checkout history with old checkouts
>=> You see 'Anonymized' for anonymized checkouts
>4) Set system preference 'AnonymousPatron' empty
>5) Look at same record checkout history
>=> Check no error
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../prog/en/modules/catalogue/issuehistory.tt              | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
>index 37c03921eb..3c85ffcbcd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
>@@ -67,12 +67,17 @@
>             <th>Checkin on</th>
>             </tr></thead>
>             <tbody>
>+        [% SET anonymous_patron_id = Koha.Preference('AnonymousPatron') || 0 %]
>         [% FOREACH checkout IN checkouts %]
>             <tr>
>                 [% IF show_patron_column %]
>                     <td>
>                         [% IF checkout.patron %][%# Not set for deleted patron records %]
>-                            [% INCLUDE 'patron-title.inc' patron => checkout.patron hide_patron_infos_if_needed=1 %]
>+                            [% IF checkout.patron.id == anonymous_patron_id %]
>+                                <em>Anonymized</em>
>+                            [% ELSE %]
>+                                [% INCLUDE 'patron-title.inc' patron => checkout.patron hide_patron_infos_if_needed=1 %]
>+                            [% END %]
>                         [% END %]
>                     </td>
>                 [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35010: 156724 | 156729 | 156760