Attachment 156870 Details for Bug 15504 – Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons

[patch] Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons

Bug-15504-follow-up-Clarify---lastseen-option-in-d.patch (text/plain), 1.73 KB, created by Martin Renvoize (ashimema) on 2023-10-11 17:14:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-10-11 17:14:27 UTC

Size: 1.73 KB

patch

obsolete

>From 59e2abbd64e3292b4326e4df2c87c0c87eeef473 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 11 Oct 2023 18:10:32 +0100
>Subject: [PATCH] Bug 15504: (follow-up) Clarify --last_seen option in
> delete_patrons
>
>This patch adds clarifications to the last_seen option in delete_patrons
>to clarify that TrackLastPatronActivity and
>TrackLastPatronActivityTriggers system preferences act as a couplet.
>---
> misc/cronjobs/delete_patrons.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/misc/cronjobs/delete_patrons.pl b/misc/cronjobs/delete_patrons.pl
>index c568c6d0272..6293bbf4421 100755
>--- a/misc/cronjobs/delete_patrons.pl
>+++ b/misc/cronjobs/delete_patrons.pl
>@@ -39,7 +39,7 @@ $expired_before = dt_from_string( $expired_before, 'iso' )
>   if $expired_before;
> 
> if ( $last_seen and not C4::Context->preference('TrackLastPatronActivity') ) {
>-    pod2usage(q{The --last_seen option cannot be used with TrackLastPatronActivity turned off});
>+    pod2usage(q{The --last_seen will be ineffective if TrackLastPatronActivity turned off or there are not TrackLastPatronActivityTriggers defined});
> }
> 
> unless ( $not_borrowed_since or $expired_before or $last_seen or @category_code or $branchcode or $file ) {
>@@ -183,9 +183,10 @@ Delete patrons with an account expired before this date.
> 
> =item B<--last_seen>
> 
>-Delete patrons who have not been connected since this date.
>+Delete patrons who have not been active since this date.
> 
>-The system preference TrackLastPatronActivity must be enabled to use this option.
>+The system preference TrackLastPatronActivity must be enabled and at least one TrackLastPatronActivityTriggers
>+must be set to use this option.
> 
> =item B<--category_code>
> 
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 15504: 152332 | 152333 | 152334 | 152335 | 152336 | 152500 | 152501 | 152502 | 152503 | 152504 | 152505 | 152506 | 155290 | 155291 | 155292 | 155293 | 155294 | 155295 | 155296 | 155534 | 155535 | 155536 | 155537 | 155538 | 155539 | 155540 | 156598 | 156599 | 156600 | 156601 | 156602 | 156603 | 156604 | 156605 | 156606 | 156607 | 156608 | 156742 | 156855 | 156856 | 156857 | 156858 | 156859 | 156860 | 156861 | 156862 | 156863 | 156864 | 156865 | 156866 | 156867 | 156868 | 156869 | 156870 | 156875 | 156879 | 156898 | 156899 | 156900 | 156901 | 156902 | 156903 | 156904 | 156905 | 156906 | 156907 | 156908 | 156909 | 156910 | 156911 | 156912 | 156913 | 156914 | 156915 | 156917 | 156918 | 156919 | 156920 | 156921 | 156922 | 156923 | 156924 | 156925 | 156926 | 156927 | 156928 | 156929 | 156930 | 156931 | 156932 | 156933 | 156934 | 156935 | 157602 | 157603 | 157604 | 157605 | 157606 | 157607 | 157608 | 157609 | 157610 | 157611 | 157612 | 157613 | 157614 | 157615 | 157616 | 157617 | 157618 | 157619 | 157620 | 157624