Bugzilla – Attachment 156882 Details for
Bug 35036
Incorrect chopping to punctuation in 246 fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35036: Do not remove punctuaction of 246 fields
Bug-35036-Do-not-remove-punctuaction-of-246-fields.patch (text/plain), 3.89 KB, created by
Lucas Gass (lukeg)
on 2023-10-11 22:13:32 UTC
(
hide
)
Description:
Bug 35036: Do not remove punctuaction of 246 fields
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2023-10-11 22:13:32 UTC
Size:
3.89 KB
patch
obsolete
>From 22b7db0c9cf4ded7e4f59714d50130754c367e34 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 11 Oct 2023 22:10:38 +0000 >Subject: [PATCH] Bug 35036: Do not remove punctuaction of 246 fields > >To test: >1. Add a 245$b to a record that ends with punctuation. ie. 'E.B.' >2. Go the record detail page on both the staff interface and OPAC. >3. The last period does not display. >4. APPLY patch and restart services >5. Look at the OPAC detail and staff interface detail pages again, the display should include punctuation >--- > .../en/xslt/MARC21slim2intranetDetail.xsl | 4 ---- > .../en/xslt/MARC21slim2OPACDetail.xsl | 20 ++++++++----------- > 2 files changed, 8 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index 3aade69a51d..6e582fb4b78 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -490,13 +490,9 @@ > </xsl:call-template> > </xsl:if> > <xsl:text> </xsl:text> >- <xsl:call-template name="chopPunctuation"> >- <xsl:with-param name="chopString"> > <xsl:call-template name="subfieldSelect"> > <xsl:with-param name="codes">abhfgnp</xsl:with-param> > </xsl:call-template> >- </xsl:with-param> >- </xsl:call-template> > <xsl:if test="@ind1=1 and not(marc:subfield[@code='i'])"> > <xsl:choose> > <xsl:when test="@ind2=0"> [Portion of title]</xsl:when> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >index a27c8b9830d..f5c26cff856 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >@@ -583,18 +583,14 @@ > <xsl:for-each select="marc:datafield[@tag=246]"> > <li> > <span property="alternateName"> >- <xsl:call-template name="chopPunctuation"> >- <xsl:with-param name="chopString"> >- <xsl:if test="marc:subfield[@code='i']"> >- <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">i</xsl:with-param> >- </xsl:call-template> >- </xsl:if> >- <xsl:text> </xsl:text> >- <xsl:call-template name="subfieldSelect"> >- <xsl:with-param name="codes">abhfgnp</xsl:with-param> >- </xsl:call-template> >- </xsl:with-param> >+ <xsl:if test="marc:subfield[@code='i']"> >+ <xsl:call-template name="subfieldSelect"> >+ <xsl:with-param name="codes">i</xsl:with-param> >+ </xsl:call-template> >+ </xsl:if> >+ <xsl:text> </xsl:text> >+ <xsl:call-template name="subfieldSelect"> >+ <xsl:with-param name="codes">abhfgnp</xsl:with-param> > </xsl:call-template> > <xsl:if test="@ind1=1 and not(marc:subfield[@code='i'])"> > <xsl:choose> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35036
:
156881
|
156882
|
156883
|
156986
|
156987
|
156991