Attachment 156908 Details for Bug 15504 – Bug 15504: (follow-up) Fix is_active test

[patch] Bug 15504: (follow-up) Fix is_active test

Bug-15504-follow-up-Fix-isactive-test.patch (text/plain), 1.01 KB, created by Martin Renvoize (ashimema) on 2023-10-12 06:18:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-10-12 06:18:54 UTC

Size: 1.01 KB

patch

obsolete

>From 0d7dfd6ed68dfa0c4b3386a893d76c42a3b81752 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 6 Oct 2023 11:37:19 +0100
>Subject: [PATCH] Bug 15504: (follow-up) Fix is_active test
>
>Bug 33245 introduced a new is_active patron method and the corresponding
>tests included calls to the method we depreacte in this patchset
>---
> t/db_dependent/Koha/Patron.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Patron.t b/t/db_dependent/Koha/Patron.t
>index 3ba784b5ce0..a38ed7ea195 100755
>--- a/t/db_dependent/Koha/Patron.t
>+++ b/t/db_dependent/Koha/Patron.t
>@@ -339,7 +339,7 @@ subtest 'is_active' => sub {
> 
>     # Check lastseen, test days parameter
>     t::lib::Mocks::mock_preference( 'TrackLastPatronActivity', 1 );
>-    $patron->track_login;
>+    $patron->update_lastseen('login');
>     is( $patron->is_active( { days => 1 } ), 1, 'Just logged in' );
>     my $ago = dt_from_string->subtract( days => 2 );
>     $patron->lastseen($ago)->store;
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 15504: 152332 | 152333 | 152334 | 152335 | 152336 | 152500 | 152501 | 152502 | 152503 | 152504 | 152505 | 152506 | 155290 | 155291 | 155292 | 155293 | 155294 | 155295 | 155296 | 155534 | 155535 | 155536 | 155537 | 155538 | 155539 | 155540 | 156598 | 156599 | 156600 | 156601 | 156602 | 156603 | 156604 | 156605 | 156606 | 156607 | 156608 | 156742 | 156855 | 156856 | 156857 | 156858 | 156859 | 156860 | 156861 | 156862 | 156863 | 156864 | 156865 | 156866 | 156867 | 156868 | 156869 | 156870 | 156875 | 156879 | 156898 | 156899 | 156900 | 156901 | 156902 | 156903 | 156904 | 156905 | 156906 | 156907 | 156908 | 156909 | 156910 | 156911 | 156912 | 156913 | 156914 | 156915 | 156917 | 156918 | 156919 | 156920 | 156921 | 156922 | 156923 | 156924 | 156925 | 156926 | 156927 | 156928 | 156929 | 156930 | 156931 | 156932 | 156933 | 156934 | 156935 | 157602 | 157603 | 157604 | 157605 | 157606 | 157607 | 157608 | 157609 | 157610 | 157611 | 157612 | 157613 | 157614 | 157615 | 157616 | 157617 | 157618 | 157619 | 157620 | 157624