Attachment 156929 Details for Bug 15504 – Bug 15504: (follow-up) Rename cache key

[patch] Bug 15504: (follow-up) Rename cache key

Bug-15504-follow-up-Rename-cache-key.patch (text/plain), 1.71 KB, created by Marcel de Rooy on 2023-10-12 09:14:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-10-12 09:14:24 UTC

Size: 1.71 KB

patch

obsolete

>From 2b83d63d8a4a8d4115afcc7f969ad2cac8050f7a Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 11 Oct 2023 17:52:43 +0100
>Subject: [PATCH] Bug 15504: (follow-up) Rename cache key
>Content-Type: text/plain; charset=utf-8
>
>I agree, it's better to use borrowernumber for the cache key and I also
>take the oportunity to rename it to more clearly reflect the function
>(it's no longer 'login' only, it's now 'activity')
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Patron.pm               | 2 +-
> t/db_dependent/Koha/Patron.t | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 574a107a6c..912d1aca20 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -1186,7 +1186,7 @@ sub update_lastseen {
>     return $self unless $tracked_activities->{$activity};
> 
>     my $cache     = Koha::Caches->get_instance();
>-    my $cache_key = "track_login_" . $self->userid;
>+    my $cache_key = "track_activity_" . $self->borrowernumber;
>     my $cached    = $cache->get_from_cache($cache_key);
>     my $now       = dt_from_string();
>     return if $cached && $cached eq $now->ymd;
>diff --git a/t/db_dependent/Koha/Patron.t b/t/db_dependent/Koha/Patron.t
>index dc0558790a..0139d3825e 100755
>--- a/t/db_dependent/Koha/Patron.t
>+++ b/t/db_dependent/Koha/Patron.t
>@@ -1964,7 +1964,7 @@ subtest 'update_lastseen tests' => sub {
>     $patron->store();
> 
>     my $cache     = Koha::Caches->get_instance();
>-    my $cache_key = "track_login_" . $patron->userid;
>+    my $cache_key = "track_activity_" . $patron->borrowernumber;
>     $cache->clear_from_cache($cache_key);
> 
>     t::lib::Mocks::mock_preference( 'TrackLastPatronActivity',         '1' );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 15504: 152332 | 152333 | 152334 | 152335 | 152336 | 152500 | 152501 | 152502 | 152503 | 152504 | 152505 | 152506 | 155290 | 155291 | 155292 | 155293 | 155294 | 155295 | 155296 | 155534 | 155535 | 155536 | 155537 | 155538 | 155539 | 155540 | 156598 | 156599 | 156600 | 156601 | 156602 | 156603 | 156604 | 156605 | 156606 | 156607 | 156608 | 156742 | 156855 | 156856 | 156857 | 156858 | 156859 | 156860 | 156861 | 156862 | 156863 | 156864 | 156865 | 156866 | 156867 | 156868 | 156869 | 156870 | 156875 | 156879 | 156898 | 156899 | 156900 | 156901 | 156902 | 156903 | 156904 | 156905 | 156906 | 156907 | 156908 | 156909 | 156910 | 156911 | 156912 | 156913 | 156914 | 156915 | 156917 | 156918 | 156919 | 156920 | 156921 | 156922 | 156923 | 156924 | 156925 | 156926 | 156927 | 156928 | 156929 | 156930 | 156931 | 156932 | 156933 | 156934 | 156935 | 157602 | 157603 | 157604 | 157605 | 157606 | 157607 | 157608 | 157609 | 157610 | 157611 | 157612 | 157613 | 157614 | 157615 | 157616 | 157617 | 157618 | 157619 | 157620 | 157624