Attachment 156958 Details for Bug 33949 – Bug 33949: Fix display of old checkouts if no checkouts exist

[patch] Bug 33949: Fix display of old checkouts if no checkouts exist

Bug-33949-Fix-display-of-old-checkouts-if-no-check.patch (text/plain), 1.58 KB, created by Nick Clemens (kidclamp) on 2023-10-12 12:29:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-10-12 12:29:54 UTC

Size: 1.58 KB

patch

obsolete

>From 53d536687baa7639a2308b33b362eb6b997544e1 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 18 Sep 2023 11:41:36 +0200
>Subject: [PATCH] Bug 33949: Fix display of old checkouts if no checkouts exist
>
>If we pass an empty array from the perl controller, we retrieve an empty
>string from the template, and the merge does not work.
>
>This patch fixes the following bug:
>Pick a patron without checkout history
>Check them an item out and check it in
>=> The table is empty, whereas it should display the item that has been
>checked in.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>index 6fe6bd9a76..dd35aca35c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>@@ -47,6 +47,8 @@
> 
>                 <div id="userreadingrecord" class="maincontent">
>                     <h1>Checkout history</h1>
>+                    [% UNLESS checkouts %][% checkouts = [] %][% END %]
>+                    [% UNLESS old_checkouts %][% old_checkouts = [] %][% END %]
>                     [% SET all_checkouts = checkouts.merge(old_checkouts) %]
>                     [% IF all_checkouts.size == 0 %]
>                         You have never borrowed anything from this library.
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33949: 152155 | 152177 | 155781 | 155782 | 156440 | 156441 | 156957 | 156958