Bugzilla – Attachment 157069 Details for
Bug 29074
DefaultHoldExpirationdatePeriod blank value interpreted as zero
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29074: Prevent undef warning when DefaultHoldExpirationdate is read
0002-Bug-29074-Prevent-undef-warning-when-DefaultHoldExpi.patch (text/plain), 1.28 KB, created by
Emmi Takkinen
on 2023-10-13 11:53:25 UTC
(
hide
)
Description:
Bug 29074: Prevent undef warning when DefaultHoldExpirationdate is read
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2023-10-13 11:53:25 UTC
Size:
1.28 KB
patch
obsolete
>From aac11af38f19438c6af0f0ab8069e753eb41d986 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Fri, 13 Oct 2023 14:30:36 +0300 >Subject: [PATCH 2/2] Bug 29074: Prevent undef warning when > DefaultHoldExpirationdate is read > >Test plan: >Repeat test plan from first patch. >Also prove t/db_dependent/Hold.t. > >Sponsored-by: Koha-Suomi Oy >--- > Koha/Hold.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index 5c818ddfee..4dfc7d2c24 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -911,6 +911,7 @@ sub store { > > if ( > C4::Context->preference('DefaultHoldExpirationdate') >+ && defined C4::Context->preference('DefaultHoldExpirationdatePeriod') > && C4::Context->preference('DefaultHoldExpirationdatePeriod') ne '' > && !$self->expirationdate > ) >@@ -926,6 +927,7 @@ sub store { > if ( exists $updated_columns{reservedate} ) { > if ( > C4::Context->preference('DefaultHoldExpirationdate') >+ && defined C4::Context->preference('DefaultHoldExpirationdatePeriod') > && C4::Context->preference('DefaultHoldExpirationdatePeriod') ne '' > && ! exists $updated_columns{expirationdate} > ) >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29074
:
144572
|
154484
|
154813
|
157068
|
157069
|
157128
|
157129
|
180628
|
180629
|
180630
|
181237
|
181249
|
182180