Bugzilla – Attachment 157087 Details for
Bug 30556
OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber
Bug-30556-Fix-CanBookBeReserved-to-return-early-if.patch (text/plain), 1020 bytes, created by
Emily-Rose Francoeur
on 2023-10-13 13:36:37 UTC
(
hide
)
Description:
Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber
Filename:
MIME Type:
Creator:
Emily-Rose Francoeur
Created:
2023-10-13 13:36:37 UTC
Size:
1020 bytes
patch
obsolete
>From 72262476641d3702fc10bdbeca2df97eb1dbfd38 Mon Sep 17 00:00:00 2001 >From: Shi Yao Wang <shi-yao.wang@inlibro.com> >Date: Fri, 29 Apr 2022 15:16:18 -0400 >Subject: [PATCH] Bug 30556: Fix CanBookBeReserved to return early if no > borrowernumber > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/Reserves.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 3625737885..87a97b8cca 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -335,6 +335,8 @@ See CanItemBeReserved() for possible return values. > sub CanBookBeReserved{ > my ($borrowernumber, $biblionumber, $pickup_branchcode, $params) = @_; > >+ return { status => '' } unless $borrowernumber; >+ > # Check that patron have not checked out this biblio (if AllowHoldsOnPatronsPossessions set) > if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions') > && C4::Circulation::CheckIfIssuedToPatron( $borrowernumber, $biblionumber ) ) { >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30556
:
133497
|
133608
|
134172
|
134420
|
134421
|
134436
|
134437
|
134438
|
134617
|
134619
|
134620
|
134621
|
135395
|
137065
|
139289
|
139290
|
139291
|
139292
|
144429
|
147378
|
147379
|
147380
|
147381
|
147382
|
147441
|
147442
|
150218
|
150219
|
150220
|
150221
|
150222
|
156188
|
156189
|
156190
|
156191
|
156192
|
156429
| 157087 |
157088
|
157089
|
157090
|
157091