Attachment 157193 Details for Bug 35057 – Bug 35057: Improve tag description labels in biblio and authority framework editing

[patch] Bug 35057: Improve tag description labels in biblio and authority framework editing

Bug-35057-Improve-tag-description-labels-in-biblio.patch (text/plain), 8.72 KB, created by Owen Leonard on 2023-10-16 13:44:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-10-16 13:44:03 UTC

Size: 8.72 KB

patch

obsolete

>From fdd25ab34aa62bdae29591641d88bc69385b308c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 16 Oct 2023 13:30:15 +0000
>Subject: [PATCH] Bug 35057: Improve tag description labels in biblio and
> authority framework editing
>
>This patch updates several templates in order to clarify labels in forms
>and on table columns.
>
>To test apply the patch and go to Administration -> Authority types ->
>MARC structure.
>
>- The second column should now be labeled "Tag description."
>- Click "Edit" on one of the tags.
>- The description fields should now be labeled "Description in staff
>  interface" and "Description in OPAC."
>- Return to the list of tags and choose Actions -> Subfields for one of
>  the tags. The second column should read "Description."
>  - Click "Edit" on one of the subfields.
>    - The description fields should now be labeled "Description in staff
>      interface" and "Description in OPAC."
>
>Go to Administration -> MARC bibliographic framework -> MARC structure.
>
>- The second column should now be labeled "Tag description."
>- Click "Edit" on one of the tags.
>- The description fields should now be labeled "Description in staff
>  interface" and "Description in OPAC."
>- Return to the list of tags and choose Actions -> Subfields for one of
>  the tags. The second column should read "Description."
>  - Click "Edit" on one of the subfields.
>    - The description fields should now be labeled "Description in staff
>      interface" and "Description in OPAC."
>---
> .../prog/en/modules/admin/auth_subfields_structure.tt       | 6 +++---
> .../prog/en/modules/admin/auth_tag_structure.tt             | 6 +++---
> .../prog/en/modules/admin/marc_subfields_structure.tt       | 4 ++--
> .../intranet-tmpl/prog/en/modules/admin/marctagstructure.tt | 6 +++---
> 4 files changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
>index e591e6b3ac..7a01667f6a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
>@@ -141,8 +141,8 @@
>                                     <input type="checkbox" id="mandatory[% loo.row | html %]" name="mandatory[% loo.row | html %]" value="1" />
>                                 [% END %]
>                             </li>
>-                            <li><label for="liblibrarian[% loo.row | html %]">Text for librarian: </label><input id="liblibrarian[% loo.row | html %]" type="text" name="liblibrarian" value="[% loo.liblibrarian | html_entity %]" size="40" maxlength="80" /></li>
>-                            <li><label for="libopac[% loo.row | html %]">Text for OPAC: </label><input type="text" id="libopac[% loo.row | html %]" name="libopac" value="[% loo.libopac | html_entity %]" size="40" maxlength="80" /></li>
>+                            <li><label for="liblibrarian[% loo.row | html %]">Description in staff interface: </label><input id="liblibrarian[% loo.row | html %]" type="text" name="liblibrarian" value="[% loo.liblibrarian | html_entity %]" size="40" maxlength="80" /></li>
>+                            <li><label for="libopac[% loo.row | html %]">Description in OPAC: </label><input type="text" id="libopac[% loo.row | html %]" name="libopac" value="[% loo.libopac | html_entity %]" size="40" maxlength="80" /></li>
>                             <li><label for="tab[% loo.row | html %]">Managed in tab: </label>
>                                 <select name="tab" id="tab[% loo.row | html %]">
>                                     [%- IF ( loo.tab ==  -1 ) -%]
>@@ -314,7 +314,7 @@
>     <thead>
>         <tr>
>             <th>Subfield</th>
>-            <th>Text</th>
>+            <th>Description</th>
>             <th>Constraints</th>
>             <th class="NoSort">&nbsp;</th>
>         </tr>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
>index b967e80737..92f8d04c1a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
>@@ -161,8 +161,8 @@
>                     </li>
>                 [% END %]
> 
>-        <li><label for="liblibrarian">Text for librarians: </label><input type="text" name="liblibrarian" id="liblibrarian" value="[% liblibrarian | html %]" size="40" maxlength="100" /></li>
>-        <li><label for="libopac">Text for opac: </label><input type="text" name="libopac" id="libopac" value="[% libopac | html %]" size="40" maxlength="100" /></li>
>+        <li><label for="liblibrarian">Description in staff interface: </label><input type="text" name="liblibrarian" id="liblibrarian" value="[% liblibrarian | html %]" size="40" maxlength="100" /></li>
>+        <li><label for="libopac">Description in OPAC: </label><input type="text" name="libopac" id="libopac" value="[% libopac | html %]" size="40" maxlength="100" /></li>
>         <li><label for="repeatable">Repeatable: </label>
>             [% IF ( repeatable ) %]
>                 <input type="checkbox" name="repeatable" id="repeatable" value="1" checked="checked" />
>@@ -269,7 +269,7 @@
>     <thead>
>         <tr>
>             <th>Tag</th>
>-            <th>Lib</th>
>+            <th>Tag description</th>
>             <th>Repeatable</th>
>             <th>Mandatory</th>
>             <th>Authorized<br />value</th>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>index 1812f10b66..8c38fd6f1e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>@@ -145,11 +145,11 @@
>                                                                 </li>
>                                                         [% END %]
>                                                         <li>
>-                                                            <label for="liblibrarian[% loo.row | html %]">Text for librarian: </label>
>+                                                            <label for="liblibrarian[% loo.row | html %]">Description in staff interface: </label>
>                                                             <input id="liblibrarian[% loo.row | html %]" type="text" name="liblibrarian_[% loo.row | html %]" value="[% loo.liblibrarian | html_entity %]" size="40" maxlength="80" />
>                                                         </li>
>                                                         <li>
>-                                                            <label for="libopac[% loo.row | html %]">Text for OPAC: </label>
>+                                                            <label for="libopac[% loo.row | html %]">Description in OPAC: </label>
>                                                             <input type="text" id="libopac[% loo.row | html %]" name="libopac_[% loo.row | html %]" value="[% loo.libopac | html_entity %]" size="40" maxlength="80" />
>                                                         </li>
>                                                         <li>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
>index 8d3c390c51..964823038f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
>@@ -148,8 +148,8 @@
>                     <span class="required">Required</span>
>                 [% END %]
>             </li>
>-    <li><label for="liblibrarian">Label for lib: </label><input type="text" id="liblibrarian" name="liblibrarian" value="[% liblibrarian | html %]" size="40" maxlength="100" /></li>
>-    <li><label for="libopac">Label for opac: </label><input type="text" id="libopac" name="libopac" value="[% libopac | html %]" size="40" maxlength="100" /></li>
>+    <li><label for="liblibrarian">Description in staff interface: </label><input type="text" id="liblibrarian" name="liblibrarian" value="[% liblibrarian | html %]" size="40" maxlength="100" /></li>
>+    <li><label for="libopac">Description in OPAC: </label><input type="text" id="libopac" name="libopac" value="[% libopac | html %]" size="40" maxlength="100" /></li>
>     <li><label for="repeatable">Repeatable: </label>
>         [% IF ( repeatable ) %]
>             <input type="checkbox" name="repeatable" id="repeatable" value="1" checked="checked" />
>@@ -265,7 +265,7 @@
>     <thead>
>         <tr>
>         <th>Tag</th>
>-        <th>Lib</th>
>+        <th>Tag description</th>
>         <th>Repeatable</th>
>         <th>Mandatory</th>
>         <th>Important</th>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35057: 157193 | 157197 | 157209