Attachment 157198 Details for Bug 34980 – Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC

[patch] Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC

Bug-34980-Remove-the-use-of-event-attributes-from-.patch (text/plain), 3.28 KB, created by ByWater Sandboxes on 2023-10-16 14:41:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2023-10-16 14:41:04 UTC

Size: 3.28 KB

patch

obsolete

>From 887af667b502d55105c74cfd3839565b857599a6 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Sat, 14 Oct 2023 14:20:00 +0000
>Subject: [PATCH] Bug 34980: Remove the use of event attributes from
> title-actions-menu.inc in OPAC
>
>This patch updates the include file used to show actions with each
>search result, removing two instances of "onclick" in favor of an event
>handler class which was already in use elsewhere.
>
>To test, apply the patch and log in to the OPAC.
>
>- Perform a catalog search which will return results.
>- Test the "Save to lists" link under any search result. The "Save to
> lists" pop-up window should appear.
>- View the contents of a list which contains some titles.
>- Test the "Save to another list" control. The same pop-up window should
> be triggered.
>- Tag at least one title in the catalog and view the "Tag cloud" page.
>- Perform the same test with the "Save to lists" button in the table of
> our tags.
>
>Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
>---
> .../opac-tmpl/bootstrap/en/includes/title-actions-menu.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
>index ecb91cf1b2..6a57bdc183 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
>@@ -50,12 +50,12 @@
> 
> [% IF ( ( Koha.Preference( 'opacuserlogin' ) == 1 ) && loggedinusername && ( Koha.Preference( 'virtualshelves' ) == 1 ) ) %]
> [% IF ( shelf AND op == 'view' ) %]
>- <a href="/cgi-bin/koha/opac-addbybiblionumber.pl?biblionumber=[% items.biblionumber | uri %]" onclick="Dopop('opac-addbybiblionumber.pl?biblionumber=[% items.biblionumber | uri %]'); return false;" class="btn btn-link btn-sm"> Save to another list</a>
>+ <a href="/cgi-bin/koha/opac-addbybiblionumber.pl?biblionumber=[% items.biblionumber | uri %]" class="addtoshelf btn btn-link btn-sm"> Save to another list</a>
> [% IF can_remove_biblios %]
> <a class="btn btn-link btn-sm removefromlist" href="/cgi-bin/koha/opac-shelves.pl?op=remove_biblios&amp;shelfnumber=[% shelf.shelfnumber | html %]&amp;biblionumber=[% items.biblionumber | html %]"> Remove from this list</a>
> [% END %]
> [% ELSE %]
>- <a class="addtoshelf btn btn-link btn-sm" href="/cgi-bin/koha/opac-addbybiblionumber.pl?biblionumber=[% items.biblionumber | html %]" onclick="Dopop('opac-addbybiblionumber.pl?biblionumber=[% items.biblionumber | html %]'); return false;"> Save to lists</a>
>+ <a class="addtoshelf btn btn-link btn-sm" href="/cgi-bin/koha/opac-addbybiblionumber.pl?biblionumber=[% items.biblionumber | html %]"> Save to lists</a>
> [% END # /IF ( shelf AND op == 'view' ) %]
> [% END # /IF Koha.Preference( 'opacuserlogin' ) %]
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34980: 157137 | 157198 | 157214