Attachment 157219 Details for Bug 35069 – Bug 35069: Fix holds to buy column sorting

[patch] Bug 35069: Fix holds to buy column sorting

Bug-35069-Fix-holds-to-buy-column-sorting.patch (text/plain), 1.48 KB, created by Lucas Gass (lukeg) on 2023-10-16 23:04:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-10-16 23:04:48 UTC

Size: 1.48 KB

patch

obsolete

>From 474d5e211176d4e8a8f786e87913a6e02367fd48 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 16 Oct 2023 23:03:03 +0000
>Subject: [PATCH] Bug 35069: Fix holds to buy column sorting
>
>This patch adds the data-sort attribute to the "Items to buy" column to ensure proper sorting.
>
>To test:
>1. Make a lot of holds.
>2. On some holds have a high enough holds/copies ratio so the "Items to buy column" has values greater than 10.
>3. Sort by that column. Notice the copies with an "Items to buy" higher than 10 do not get sorted correctly.
>4. APPLY PATCH
>5. Try steps 1 -3 again. Everything should sort properly.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
>index 222f695d0eb..6efc3e0263f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
>@@ -108,7 +108,7 @@
>                       [% END %]
>                   </ul>
>             </td>
>-            <td class="actions">
>+            <td class="actions" data-sort="[% reserveloo.copies_to_buy | html %]">
>                 <p>
>                     [% IF ( reserveloo.thisratio_atleast1 ) %]
>                         [% IF ( CAN_user_acquisition && basketno && booksellerid ) %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35069: 157219 | 157225 | 157287