Bugzilla – Attachment 157230 Details for
Bug 34077
writeoff_debts without --confirm doesn't show which accountline records it would have been written off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34077: Update output to match POD
Bug-34077-Update-output-to-match-POD.patch (text/plain), 1.43 KB, created by
Martin Renvoize (ashimema)
on 2023-10-17 11:51:01 UTC
(
hide
)
Description:
Bug 34077: Update output to match POD
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-10-17 11:51:01 UTC
Size:
1.43 KB
patch
obsolete
>From f08b294b364100063391fa02305e1c29389e92a3 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 17 Oct 2023 12:49:55 +0100 >Subject: [PATCH] Bug 34077: Update output to match POD > >This patch adds a check on !$confirm such that we enable verbose output >should the confirm flag not be passed. This adheres with what the >documentation already states. >--- > misc/cronjobs/writeoff_debts.pl | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/misc/cronjobs/writeoff_debts.pl b/misc/cronjobs/writeoff_debts.pl >index 1fc7ce18e38..f546df77b90 100755 >--- a/misc/cronjobs/writeoff_debts.pl >+++ b/misc/cronjobs/writeoff_debts.pl >@@ -60,8 +60,9 @@ if ($after) { > } > > my $lines = Koha::Account::Lines->search( $where, $attr ); >-if ( $verbose ) { >- print "Attempting to write off " . $lines->count . " debts"; >+if ( $verbose || !$confirm ) { >+ print "Attempting to write off " . $lines->count . " debts" if $confirm; >+ print "With --confirm we would write off " . $lines->count . " debts" if !$confirm; > print " of type " . join(',',@type) if @type; > print " added before " . $before if $before; > print " from the passed list" if $file; >@@ -115,7 +116,7 @@ while ( my $line = $lines->next ) { > ); > } > >- if ($verbose) { >+ if ($verbose || !$confirm) { > if ($confirm) { > say "Accountline " . $line->accountlines_id . " written off"; > } >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34077
:
157230
|
159598
|
159987
|
161772
|
161773
|
161774
|
162234
|
162235
|
167403
|
167404