Bugzilla – Attachment 15724 Details for
Bug 9719
Changing the rows per page on a custom report fails if it has user supplied parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters
Bug-9719---Changing-the-rows-per-page-on-a-custom-.patch (text/plain), 2.53 KB, created by
Kyle M Hall (khall)
on 2013-02-27 13:51:00 UTC
(
hide
)
Description:
Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-02-27 13:51:00 UTC
Size:
2.53 KB
patch
obsolete
>From 32a5db0b6a7a3afcc3cce9511e056ad2013b1e30 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 27 Feb 2013 08:46:56 -0500 >Subject: [PATCH] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters > >If you create an SQL report that includes one or more parameters, >using the 'rows per page' pulldown does not work. Instead, it will >prompt for the parameters again and shows the first page of output. > >Test Plan: >1) Create a new report from sql as follows: > SELECT * FROM borrowers WHERE surname LIKE <<Last Name>> AND firstname LIKE <<First Name>> >2) Run this report >3) Change the 'Rows per page' and click 'Update' >4) This should kick you back to the start where the report asks you for your parameters >5) Apply the patch >6) Repeat step 3, this time is should work correctly >--- > .../en/modules/reports/guided_reports_start.tt | 6 +++++- > reports/guided_reports.pl | 1 + > 2 files changed, 6 insertions(+), 1 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 7f109d9..0cd2f6b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -580,10 +580,14 @@ canned reports and writing custom SQL reports.</p> > [% IF ( unlimited_total ) %]<p>Total number of rows matching the (unlimited) query is [% unlimited_total %].</p>[% END %] > <pre id="sql_output">[% sql |html %]</pre> > >-<form> >+<form action="/cgi-bin/koha/reports/guided_reports.pl" method="get"> > <input type="hidden" name="phase" value="Run this report"/> > <input type="hidden" name="reports" value="[% report_id %]"/> > >+ [% FOREACH p IN sql_params %] >+ <input type="hidden" name="sql_params" value="[% p %]"/> >+ [% END %] >+ > <label for="limit">Rows per page: </label> > <select name="limit"> > [% limits = [ 10, 20, 50, 100, 200, 300, 400, 500, 1000 ] %] >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index 23d85a9..6e5fe3e 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -673,6 +673,7 @@ elsif ($phase eq 'Run this report'){ > 'errors' => $errors, > 'pagination_bar' => pagination_bar($url, $totpages, $input->param('page')), > 'unlimited_total' => $total, >+ 'sql_params' => \@sql_params, > ); > } > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9719
:
15724
|
17851
|
17865