Attachment 157270 Details for Bug 22632 – Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm

[patch] Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm

Bug-22632-follow-up-Perltidy-fixes-for-KohaPatronp.patch (text/plain), 1.45 KB, created by David Nind on 2023-10-17 16:30:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-10-17 16:30:06 UTC

Size: 1.45 KB

patch

obsolete

>From 0965b1c3a5e70f2a8d7cff1e7aedc3d82b3d017b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 17 Oct 2023 15:50:28 +0000
>Subject: [PATCH] Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/Patron.pm | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 9988fb8cde..7540334f60 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -677,9 +677,16 @@ sub merge_with {
>             $patron->move_to_deleted();
>             $patron->delete();
> 
>-            if (C4::Context->preference("BorrowersLog")){
>-                my $info = $patron->firstname. " " . $patron->surname . " (".$patron->cardnumber . ")". " has been merged into " . $self->firstname . " " . $self->surname . " (".$self->cardnumber . ")" ;
>-                logaction("MEMBERS", "PATRON_MERGE", $self->id, $info );
>+            if ( C4::Context->preference("BorrowersLog") ) {
>+                my $info =
>+                        $patron->firstname . " "
>+                    . $patron->surname . " ("
>+                    . $patron->cardnumber . ")"
>+                    . " has been merged into "
>+                    . $self->firstname . " "
>+                    . $self->surname . " ("
>+                    . $self->cardnumber . ")";
>+                logaction( "MEMBERS", "PATRON_MERGE", $self->id, $info );
>             }
>         }
>     });
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 22632: 87778 | 87920 | 87921 | 87922 | 87923 | 87926 | 87995 | 87996 | 87997 | 87998 | 87999 | 88043 | 88044 | 88045 | 88046 | 89728 | 89729 | 89730 | 89731 | 157260 | 157261 | 157262 | 157263 | 157264 | 157265 | 157266 | 157267 | 157268 | 157269 | 157270 | 157271 | 157278 | 157281 | 157286 | 159553 | 159554 | 159555 | 159556 | 159557 | 159558