Attachment 157287 Details for Bug 35069 – Bug 35069: Fix hold ratios items needed column sorting

[patch] Bug 35069: Fix hold ratios items needed column sorting

Bug-35069-Fix-hold-ratios-items-needed-column-sort.patch (text/plain), 1.61 KB, created by Emily Lamancusa (emlam) on 2023-10-17 19:52:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2023-10-17 19:52:14 UTC

Size: 1.61 KB

patch

obsolete

>From 1b58933c8163dfa3a221949241ae3eb562497f5e Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 16 Oct 2023 23:03:03 +0000
>Subject: [PATCH] Bug 35069: Fix hold ratios items needed column sorting
>
>This patch adds the data-sort attribute to the "Items needed" column to
>ensure proper sorting.
>
>To test:
>1. Make a lot of holds.
>2. On some holds have a high enough holds/copies ratio so the "Items
>   needed" has values greater than 10.
>3. Sort by that column. Notice the copies with an "Items needed" higher
>   than 10 do not get sorted correctly.
>4. APPLY PATCH
>5. Try steps 1 -3 again. Everything should sort properly.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
>index 222f695d0e..6efc3e0263 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
>@@ -108,7 +108,7 @@
>                       [% END %]
>                   </ul>
>             </td>
>-            <td class="actions">
>+            <td class="actions" data-sort="[% reserveloo.copies_to_buy | html %]">
>                 <p>
>                     [% IF ( reserveloo.thisratio_atleast1 ) %]
>                         [% IF ( CAN_user_acquisition && basketno && booksellerid ) %]
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35069: 157219 | 157225 | 157287