Attachment 157296 Details for Bug 32602 – Bug 32602: SIP server doesn't respect IssuingInProcess system preference

[patch] Bug 32602: SIP server doesn't respect IssuingInProcess system preference

Bug-32602-SIP-server-doesnt-respect-IssuingInProce.patch (text/plain), 2.18 KB, created by Aleisha Amohia on 2023-10-18 01:00:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2023-10-18 01:00:21 UTC

Size: 2.18 KB

patch

obsolete

>From 507ccfac66a2bccac7cfcbabe0b44edc5907926f Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleisha@catalyst.net.nz>
>Date: Wed, 18 Oct 2023 00:59:09 +0000
>Subject: [PATCH] Bug 32602: SIP server doesn't respect IssuingInProcess system
> preference
>
>The system preference 'IssuingInProcess' when set to "Don't prevent" means patrons will still be allowed to issue items if their rental charge took the patron over the noissuescharge system preference.
>
>However, SIP returns that a patron is fine blocked (even if 'IssuingInProcess' equals "Don't prevent") when they try to issue items that take them over the noissuecharge amount.
>
>Test plan:
>1. Configure the BK item type to have a rental charge of $2
>2. Configure system preferences:
>- noissuescharge = $5
>- IssuingInProcess = Don't prevent
>3. From a SIP2 device issue 3 BK items to a borrower and notice after the 2nd item you
>cannot issue the third item
>
>4. Apply patches
>5. Restart your SIP2 server
>6. From a SIP2 device issue 3 BK items to a different patron and notice you can issue all
>three items
>
>Sponsored-by: Horowhenua District Council, New Zealand
>---
> C4/Circulation.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 2ebe5cbe6e3..23ad5f2d296 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -894,11 +894,11 @@ sub CanBookBeIssued {
>     }
> 
>     if ( C4::Context->preference("IssuingInProcess") ) {
>-        if ( $non_issues_charges > $amountlimit && !$inprocess && !$allowfineoverride) {
>+        if ( $non_issues_charges > $amountlimit && !$allowfineoverride) {
>             $issuingimpossible{DEBT} = $non_issues_charges;
>-        } elsif ( $non_issues_charges > $amountlimit && !$inprocess && $allowfineoverride) {
>+        } elsif ( $non_issues_charges > $amountlimit && $allowfineoverride) {
>             $needsconfirmation{DEBT} = $non_issues_charges;
>-        } elsif ( $allfinesneedoverride && $non_issues_charges > 0 && $non_issues_charges <= $amountlimit && !$inprocess ) {
>+        } elsif ( $allfinesneedoverride && $non_issues_charges > 0 && $non_issues_charges <= $amountlimit ) {
>             $needsconfirmation{DEBT} = $non_issues_charges;
>         }
>     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32602: 145170 | 145249 | 149152 | 149153 | 156808 | 156809 | 157296 | 157297