Bugzilla – Attachment 157366 Details for
Bug 35078
Invalid HTML in OpacShowSavings system preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35078: Remove invalid HTML from OpacShowSavings system preference
Bug-35078-Remove-invalid-HTML-from-OpacShowSavings.patch (text/plain), 2.38 KB, created by
Victor Grousset/tuxayo
on 2023-10-18 23:55:08 UTC
(
hide
)
Description:
Bug 35078: Remove invalid HTML from OpacShowSavings system preference
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2023-10-18 23:55:08 UTC
Size:
2.38 KB
patch
obsolete
>From fab5396ef8ac36869ea09abf8efbcccd58865f3f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 17 Oct 2023 13:51:49 +0000 >Subject: [PATCH] Bug 35078: Remove invalid HTML from OpacShowSavings system > preference > >The options defined for the OpacShowSavings system preference contain >HTML: "on patron's checkout history page (the system preference ><em>opacreadinghistory</em> must be enabled)". This text ends up in an ><option> tag, and even though the form is rendered using the >multiple-select plugin the HTML still won't render and should >be removed. > >To test, apply the patch and restart all. > >- Go to Administration -> System preferences and search for > "OpacShowSavings" >- Check the dropdown of options on the preference. The system > preference names referred to should now be single-quoted instead of > wrapped in visible <em> tags. >- Confirm that the preference still works correctly. > >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >index be8620a2fa..2dccc48525 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >@@ -547,8 +547,8 @@ OPAC: > - "Calculate the amount a patron has 'saved' by using the library based on replacement prices, and display:" > - pref: OPACShowSavings > multiple: >- checkouthistory: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)" >- summary: "in user summary box on OPAC homepage (the system preference <em>OPACUserSummary</em> must be enabled)" >+ checkouthistory: "on patron's checkout history page (the system preference 'opacreadinghistory' must be enabled)" >+ summary: "in user summary box on OPAC homepage (the system preference 'OPACUserSummary' must be enabled)" > user: "on patron's 'your summary' page" > - ". Note that displayed savings may be inaccurate if checkout history is anonymized." > OpenURL: >-- >2.42.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35078
:
157251
|
157252
| 157366