Bugzilla – Attachment 157405 Details for
Bug 34014
There is no way to fix records with broken MARCXML
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34014: (follow-up) No need to parse old record before updating
Bug-34014-follow-up-No-need-to-parse-old-record-be.patch (text/plain), 1.21 KB, created by
Martin Renvoize (ashimema)
on 2023-10-19 09:33:19 UTC
(
hide
)
Description:
Bug 34014: (follow-up) No need to parse old record before updating
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-10-19 09:33:19 UTC
Size:
1.21 KB
patch
obsolete
>From 053c05b29839a2ac3a66b5e82fea45bb4d438d05 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 17 Oct 2023 19:15:24 +0000 >Subject: [PATCH] Bug 34014: (follow-up) No need to parse old record before > updating > >If the old record doesn't parse correctly it will cause a failure - the check is just to ensure we >are editing an existing biblio, just getting the metadata object should confirm it exists > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > svc/bib | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/svc/bib b/svc/bib >index 206778058b0..0667c0de4ba 100755 >--- a/svc/bib >+++ b/svc/bib >@@ -89,7 +89,7 @@ sub update_bib { > my $query = shift; > my $biblionumber = shift; > my $biblio = Koha::Biblios->find( $biblionumber ); >- my $old_record = $biblio->metadata->record; >+ my $old_record = $biblio->metadata; > my $frameworkcode = $query->url_param('frameworkcode') // GetFrameworkCode($biblionumber); > unless (defined $old_record) { > print $query->header(-type => 'text/xml', -status => '404 Not Found'); >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34014
:
152360
|
157274
|
157275
|
157276
|
157277
|
157280
|
157401
|
157402
|
157403
|
157404
| 157405