Attachment 157420 Details for Bug 35096 – Bug 35096: Fix batch accessor in ILL request page

[patch] Bug 35096: Fix batch accessor in ILL request page

Bug-35096-Fix-batch-accessor-in-ILL-request-page.patch (text/plain), 2.45 KB, created by Martin Renvoize (ashimema) on 2023-10-19 11:00:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-10-19 11:00:52 UTC

Size: 2.45 KB

patch

obsolete

>From 07f874ce36c931f650329ab873baabb916364d06 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Wed, 18 Oct 2023 16:11:48 +0000
>Subject: [PATCH] Bug 35096: Fix batch accessor in ILL request page
>
>Test plan, k-t-d:
>1) Install FreeForm and enable ILLmodule, run:
>bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
>2) Install an ILL availability plugin (e.g. pubmed):
>https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
>3) restart plack:
>koha-plack --restart kohadev
>4) Create a new ILL batch, visit:
>/cgi-bin/koha/ill/ill-requests.pl
>5) Click '+New ILL requests batch'
>6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'.
>7) On the identifiers textarea, insert '123' and click 'Process identifiers'
>8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch'
>9) You should now be seeing 'View ILL requests for batch <batch_name>' with the request you just added.
>10) Click the request id (or the 'Manage request' button)
>11) Notice you can view the request correctly, the batch it belongs to shows correctly and is clickable
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>index 86c02117a92..87d73fc747c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
>@@ -669,8 +669,8 @@
>                                 [% IF request.ill_batch > 0 %]
>                                 <li class="batch">
>                                     <span class="label batch">Batch:</span>
>-                                    <a href="/cgi-bin/koha/ill/ill-requests.pl?batch_id=[% request.batch.ill_batch_id | uri %]">
>-                                    [% request.batch.name | html %]
>+                                    <a href="/cgi-bin/koha/ill/ill-requests.pl?batch_id=[% request.ill_batch.ill_batch_id | uri %]">
>+                                    [% request.ill_batch.name | html %]
>                                     </a>
>                                 </li>
>                                 [% END %]
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 35096: 157339 | 157365 | 157420