Bugzilla – Attachment 157529 Details for
Bug 35119
Make bibliographic encoding errors more prominent and match current styling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35119: Use page-section and bg-danger on biblio errors
Bug-35119-Use-page-section-and-bg-danger-on-biblio.patch (text/plain), 2.74 KB, created by
Martin Renvoize (ashimema)
on 2023-10-20 14:37:54 UTC
(
hide
)
Description:
Bug 35119: Use page-section and bg-danger on biblio errors
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-10-20 14:37:54 UTC
Size:
2.74 KB
patch
obsolete
>From 994490da51473085896db1182ebdef83ccbf116f Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 20 Oct 2023 15:35:12 +0100 >Subject: [PATCH] Bug 35119: Use page-section and bg-danger on biblio errors > >This patch uses the page-section and bg-danger classes to increase the >prominence of bibliographic record errors in the staff client to >encourage staff to fix such issues as soon as possible. > >Test plan >1) Using ktd navigate to record 369 >2) Note the display of an encoding warning at the top of the page >3) Apply the patch >4) Refresh the above page and note the stronger visual prominence of the > error >--- > .../prog/en/modules/catalogue/detail.tt | 28 ++++++++++--------- > 1 file changed, 15 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index a3c08aa693c..cdfa1db0c66 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -92,19 +92,6 @@ > [% SyndeticsCovers = Koha.Preference('SyndeticsEnabled') && Koha.Preference('SyndeticsCoverImages') %] > > [% INCLUDE 'cat-toolbar.inc' %] >- [% IF decoding_error %] >- <div> >- <span class="biberror"> >- There is an error with this bibliographic record, the view may be degraded.</span> >- <span class="error"><br/> Error: [% decoding_error | html %]</span> >- </div> >- [% END %] >- [% IF analytics_error %] >- <div> >- <span class="analytics_error"> >- There was an error searching for analytic records, please see the logs for details.</span> >- </div> >- [% END %] > [% IF ( ocoins ) %] > <!-- COinS / OpenURL --> > <span class="Z3988" title="[% ocoins | html %]"></span> >@@ -115,6 +102,21 @@ > [% ELSE %] > <div id="catalogue_detail_biblio" class="col-xs-12"> > [% END %] >+ [% IF decoding_error || analytics_error %] >+ <div class="page-section bg-danger"> >+ <h1>Errors found</h1> >+ [% IF decoding_error %] >+ <h2>Encoding errors</h2> >+ <p>There is at least one encoding error with this bibliographic record, the view may be degraded.</p> >+ <span class="error"><br/> Error details: [% decoding_error | html %]</span> >+ [% END %] >+ [% IF analytics_error %] >+ <h2>Analytics errors</h2> >+ <p>There was an error searching for analytic records, please see the logs for details.</p> >+ [% END %] >+ </div> >+ [% END %] >+ > <div class="page-section"> > > [% XSLTBloc | $raw %] >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35119
:
157529
|
157538
|
157553
|
157561
|
157577
|
157578
|
157641
|
157643
|
157644
|
157645
|
157984
|
157985