Bugzilla – Attachment 157561 Details for
Bug 35119
Make bibliographic encoding errors more prominent and match current styling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35119: (follow-up) Same treatment for editor page
Bug-35119-follow-up-Same-treatment-for-editor-page.patch (text/plain), 2.15 KB, created by
Martin Renvoize (ashimema)
on 2023-10-20 18:21:44 UTC
(
hide
)
Description:
Bug 35119: (follow-up) Same treatment for editor page
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-10-20 18:21:44 UTC
Size:
2.15 KB
patch
obsolete
>From c361a62072647bed5938351af9acbd3e430053bd Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 20 Oct 2023 19:18:43 +0100 >Subject: [PATCH] Bug 35119: (follow-up) Same treatment for editor page > >We pushed 34014 before I thought about these changes.. I think this is a >solid follow-up to add the same styling to the catalogue editor page.. >swapping the existing dialog alert with a page-section bg-danger and >thus allowing more space to 'pre' wrap the encoding error itself to ease >the spotting of errant characters. >--- > .../prog/en/modules/cataloguing/addbiblio.tt | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index f295787aa0c..c53176fac22 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -838,14 +838,15 @@ $(document).ready(function(){ > [% END #/ WRAPPER sub-header.inc %] > > <div class="main container-fluid"> >- [% IF ( INVALID_METADATA ) %] >- <div class="dialog alert"> >- <p>This record had encoding issues, non-xml characters have been stripped in order to allow editing. Please be cautious when saving that some data may have been removed from the record.</br>Decoding error:</p> >- <span class="problem">[% INVALID_METADATA | html %]</span> >- </div> >- [% END %] > <div class="row"> > <div class="col-md-10 col-md-offset-1"> >+ [% IF ( INVALID_METADATA ) %] >+ <div class="page-section bg-danger"> >+ <h1>Errors found</h1> >+ <p><strong>This record had encoding issues, non-xml characters have been stripped in order to allow editing. Please be cautious when saving that some data may have been removed from the record.</strong></p> >+ <pre class="problem">[% INVALID_METADATA | html %]</pre> >+ </div> >+ [% END %] > > <div id="check_errors"></div> > >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35119
:
157529
|
157538
|
157553
|
157561
|
157577
|
157578
|
157641
|
157643
|
157644
|
157645
|
157984
|
157985