Attachment 157573 Details for Bug 34422 – Bug 34422: (follow-up) Add markup comments

[patch] Bug 34422: (follow-up) Add markup comments

Bug-34422-follow-up-Add-markup-comments.patch (text/plain), 4.02 KB, created by Katrin Fischer on 2023-10-20 20:20:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-10-20 20:20:29 UTC

Size: 4.02 KB

patch

obsolete

>From aa9e40a80052fade2c976721209f7c8018c82111 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 26 Jul 2023 16:40:39 +0000
>Subject: [PATCH] Bug 34422: (follow-up) Add markup comments
>
>This patch adds comments to the template to highlight the markup
>structure.
>
>This patch should have no effect on the page's appearance or
>functionality.
>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/includes/facets.inc | 23 ++++++++++---------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>index 170961c3e2..31e5de73b5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>@@ -21,10 +21,10 @@
>                                         <span class="filter_label"><a href="[% base_url _ '&limit=search_filter:' _ search_filter_id | $raw %]">[% search_filter.name | html %]</a></span>
>                                     [% END %]
>                                 </li>
>-                            [% END %]
>+                            [% END # /FOREACH search_filter %]
>                         </ul>
>                     </li>
>-                [% END %]
>+                [% END # /IF SavedSearchFilters %]
>                 <li id="availability_facet">
>                     Availability
>                     <ul>
>@@ -35,7 +35,8 @@
>                                 <li>
>                                     <a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi_not_availablity | $raw %][% IF ( sort_by ) %]&amp;sort_by=[% sort_by | uri %][% END %]">Show all records</a>
>                             [% ELSE %]
>-                                <a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %][% IF ( sort_by ) %]&amp;sort_by=[% sort_by | uri %][% END %]&amp;limit=available">Limit to records with available items</a>[% END %]
>+                                <a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi | $raw %][% limit_cgi | $raw %][% IF ( sort_by ) %]&amp;sort_by=[% sort_by | uri %][% END %]&amp;limit=available">Limit to records with available items</a>
>+                            [% END # /IF available %]
>                         </li>
>                     </ul>
>                     [% IF ( related ) %]
>@@ -43,7 +44,7 @@
>                             (related searches: [% FOREACH relate IN related %][% relate.related_search | html %][% END %])
>                         </li>
>                     [% END %]
>-                </li>
>+                </li> 
> 
>                 [% FOREACH facets_loo IN facets_loop %]
>                     [% IF facets_loo.facets.size > 0 %]
>@@ -112,9 +113,9 @@
>                                             [% IF ( displayFacetCount ) %]
>                                                 <span class="facet-count"> ([% facet.facet_count | html %])</span>
>                                             [% END %]
>-                                        [% END %]
>+                                        [% END # /IF facet.active %]
>                                     </li>
>-                                [% END %]
>+                                [% END # /FOREACH facet %]
>                                 [% IF facets_loo.facets.size > 5 %]
>                                     <li class="moretoggle">
>                                         <a href="#"><strong>Show more</strong></a>
>@@ -125,9 +126,9 @@
>                                 [% END %]
>                             </ul>
>                         </li>
>-                    [% END %]
>-                [% END %]
>+                    [% END # /IF facets_loo.facets.size %]
>+                [% END # /FOREACH facets_loo %]
>             </ul>
>-        </div>
>-    [% END %]
>-[% END %]
>+        </div> 
>+    [% END # /IF ( facets_loop ) %]
>+[% END # /IF ( opacfacets ) %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34422: 153930 | 153931 | 154080 | 154081 | 154082 | 154700 | 154701 | 157272 | 157273 | 157572 | 157573