Bugzilla – Attachment 157579 Details for
Bug 33810
Accessibility: OPAC Advanced Search fields are not labelled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33810: Opac advanced search fields need aria-labels
Bug-33810-Opac-advanced-search-fields-need-aria-la.patch (text/plain), 2.46 KB, created by
Emily Lamancusa (emlam)
on 2023-10-20 20:49:43 UTC
(
hide
)
Description:
Bug 33810: Opac advanced search fields need aria-labels
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2023-10-20 20:49:43 UTC
Size:
2.46 KB
patch
obsolete
>From 00240ec24c07ce53d07de038fd7f0b439f06cc92 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Tue, 23 May 2023 14:49:08 +0000 >Subject: [PATCH] Bug 33810: Opac advanced search fields need aria-labels > >The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs > >Signed-off-by: joubu <xxx@example.org> >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >index 133b352c66..0d5411358f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >@@ -52,7 +52,7 @@ > </div> <!-- .search-term-input --> > > <div class="search-term-input"> >- <select class="form-control" name="idx" id="search-field_[% loop.index | html %]"> >+ <select class="form-control" name="idx" aria-label="Choose search type for field [% loop.index + 1 | html %]" id="search-field_[% loop.index | html %]"> > <option value="kw">Keyword</option> > [% IF ( expanded_options ) %] > <option value="kw,phr"> Keyword phrase</option> >@@ -107,7 +107,7 @@ > </select> <!-- /#search-field_[% loop.index | html %] --> > </div> <!-- .search-term-input --> > <div class="search-term-input"> >- <input class="form-control" type="text" name="q" title="Enter search terms" value="" /> >+ <input class="form-control" type="text" name="q" aria-label="Enter field [% loop.index + 1 | html %] search terms" value="" /> > </div> <!-- .search-term-input --> > [% IF ( expanded_options ) %] > <div class="search-term-input"> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33810
:
151577
|
151618
|
154493
|
154498
| 157579