Attachment 157581 Details for Bug 35124 – Bug 35124: Incorrect item groups table markup

[patch] Bug 35124: Incorrect item groups table markup

Bug-35124-Incorrect-item-groups-table-markup.patch (text/plain), 1.77 KB, created by David Nind on 2023-10-20 23:36:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-10-20 23:36:12 UTC

Size: 1.77 KB

patch

obsolete

>From 56ec7e792f4a44953bffd9c2e5ebea18bba27981 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 20 Oct 2023 17:01:00 +0000
>Subject: [PATCH] Bug 35124: Incorrect item groups table markup
>
>This patch corrects the markup of the item groups table which is found
>under the "Item groups" tab on the bibliographip detail page in the
>staff interface.
>
>The patch also adds the "NoSort" class to the "actions" column to
>prevent it from being sortable.
>
>To test, apply the patch and make sure the "EnableItemGroups" system
>preference is enabled.
>
>- In the staff interface, locate a record with items and view the detail
>  page.
>- Under the "Item groups" tab confirm that the table looks correct: The
>  heading labels should be centered bold text.
>- You should see sorting indicators on the "Display order" and "Description"
>  headings but not on the last one.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index a3c08aa693..562532a27a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -673,9 +673,9 @@
>         <table class="items-group-table" id="items-group-table">
>             <thead>
>                 <tr>
>-                    <td>Display order</td>
>-                    <td>Description</td>
>-                    <td>&nbsp;</td>
>+                    <th>Display order</th>
>+                    <th>Description</th>
>+                    <th class="NoSort">&nbsp;</th>
>                 </tr>
>             </thead>
>         </table>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35124: 157558 | 157581 | 157593